Closed Bug 978753 Opened 10 years ago Closed 10 years ago

Tests for purple/ are not running when |make xpcshell-tests|

Categories

(Instantbird Graveyard :: Other, defect)

Product:
Instantbird Graveyard
Component:
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(1 file, 1 obsolete file)

Fix
947 bytes, patch
florian
: review+
Details | Diff | Splinter Review 
Currently the xpcshell tests aren't running when building purple/ from an extension.
Summary: xpcshells for purple/ not running → Tests for purple/ are not running when |make xpcshell-tests|
Attached patch Fix (obsolete) — — Splinter Review 
This fixes the path to add the necessary /extensions folder, If purple/ was not built a warning will be thrown in the console, but this isn't a big deal.
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #8388126 - Flags: review?(florian)
Attached patch Fix — — Splinter Review 
Sorry, I uploaded the wrong patch.
Attachment #8388126 - Attachment is obsolete: true
Attachment #8388126 - Flags: review?(florian)
Attachment #8388127 - Flags: review?(florian)
Attachment #8388127 - Flags: review?(florian) → review+
FYI the mozilla/ is not needed (as would be expected) since xpcshell tests run with a root of <objdir>/mozilla/_tests/xpcshell, inside of this there is an extensions folder, if you run:
|ls <objdir>/mozilla/_tests/xpcshell/extensions| there's a purple directory that will get run.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/a262fe4c12a9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.