978786 - [meta] Implement new language picker for all our apps

Status: RESOLVED FIXED

(Webmaker Graveyard :: Localization, defect)

Description

[Ali Al Dallal [:alicoding]]

We are going to have a long list of supported languages and I think Kate's new design is needed as it's more friendly to use and well designed.

Comment 1

[inactivate account for kate]

I think so far your implementation is looking good so far. Happy to review/and or help if needed

Comment 2

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/webmaker.org/pull/621

Comment 3

[inactivate account for kate]

Comment on attachment 8385597 [details] [review]
https://github.com/mozilla/webmaker.org/pull/621

Code looks good, one suggestion for the http://localhost:7777/en-US/languages page:

Because the languages are all different sizes, they look a little weird and uneven. Can you do CSS columns instead of floats, so they line up?

Also, for mobile on that page, let's make them a single column

Comment 4

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/482

Comment 5

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/384

Comment 6

[inactivate account for kate]

Comment on attachment 8385597 [details] [review]
https://github.com/mozilla/webmaker.org/pull/621

One comment in the PR

Comment 7

[inactivate account for kate]

Comment on attachment 8386859 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/482

It looks pretty weird on the side... can you move it to the bottom and have the tip on the top?

Comment 8

[inactivate account for kate]

Comment on attachment 8386860 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/384

Same thing here, just change it to the bottom

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/1aa66174913f0e9cfb8736e864864b518e87ad19
Bug978786 - Implement new language picker

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/963e18f006fdc6f69e41ebfb339cac7a3a1db23b
Bug978786 - Implement new language picker

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/d21d3e5425f8d22c0336092be14a380a44ab6186
bug978786 - Implement new language picker

Comment 12

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/107

adding pomax to review this as well for part adding nunjucks enabled for bower_components since I don't know if there is a reason it wasn't done for webmaker-auth-client?

Comment 13

[inactivate account for kate]

Comment on attachment 8387305 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/107

R+ one style nit

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org

https://github.com/mozilla/goggles.webmaker.org/commit/90cc8d66c3322ea05baf3f27358eeac94ceaf5cd
bug978786 - Implement new language picker

Comment 15

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/244

Comment 16

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/a302ddd90548a98f9e6f22e349527af6cd668bd3
bug978786 - Implement new language picker