978853 - sdk/ui/button doesn't render icons under Linux

Status: RESOLVED INVALID

(Add-on SDK Graveyard :: General, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: test-addon.tgz

I haven't tested other platforms.

STR:

1) Make the simplest possible addon using sdk/ui/button (see attached tarball)
2) No icon appears in nav toolbar or customization menu

From the logs:

(firefox:24517): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::display after class was initialised
[24517] WARNING: Attempt to add property GnomeProgram::default-icon after class was initialised: 'glib warning', file /builds/slave/m-cen-l64-ntly-000000000000000/build/toolkit/xre/nsSigHandlers.cpp, line 127

Comment 1

[Dave Townsend [:mossop]]

Matteo can you check this out please, we may need to add this to the list of urgent items for Aurora.

Monica, why does this depend on bug 978838?

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

The icons needs to be in the `data` folder, as any other regular assets.

> icon: a string in the form "./iconfile", where "iconfile" is a relative path to the icon file beginning in your add-on's "data" directory
(https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_button_action)

Let me know if it's working in that way.

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #2)
> The icons needs to be in the `data` folder, as any other regular assets.
> 
> > icon: a string in the form "./iconfile", where "iconfile" is a relative path to the icon file beginning in your add-on's "data" directory
> (https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/
> ui_button_action)
> 
> Let me know if it's working in that way.

Yes, that seemed to work. Thanks.