978870 - Implement a proper fix regarding the need to log in to sqlite-based NSS databases, particularly regarding

Status: RESOLVED DUPLICATE of bug 1389664

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

In bug 978120, we implemented a hack to get nsIX509Cert.addCert and nsIX509Cert.setCertTrust to work in Android and B2G xpcshell tests; see attemptToLogInWithDefaultPassword in nsNSSCertificateDB.cpp. Luckily these functions are not used in Android or B2G except for the tests.

However, it is likely that somebody will eventually try to use these functions on Android and B2G, and we should make sure they do the correct thing, or we should remove them.

Two unanswered questions:

1. What happens when we call PK11_InitPin to log in with the default blank password when the user has set a different password?

2. If we call PK11_InitPin with the default blank password, then will the user be able to log in later with the correct master password? Or, does anything that needs the master password just break?

Comment 1

[Dana Keeler (she/her) [:keeler]]

(In reply to Brian Smith (:briansmith, :bsmith, use NEEDINFO?) from comment #0)
> 1. What happens when we call PK11_InitPin to log in with the default blank
> password when the user has set a different password?

PK11_InitPin returns SECFailure, and nothing happens.

> 2. If we call PK11_InitPin with the default blank password, then will the
> user be able to log in later with the correct master password? Or, does
> anything that needs the master password just break?

If they don't already have a password, it'll set a blank one. They can then set the password to a non-blank one if they wish.