978912 - Mapping "->" to "->" in Notes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Notes, defect)

Description

[André Jaenisch]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.102 Safari/537.36

Steps to reproduce:

1. Start Notes app in Firefox OS v1.1 (Alcatel OneTouch Fire).
2. Add a new note.
3. Enter "->" in the text field.
4. Save by hitting "Done." (leads to closing this note)
5. Reopen the note.


Actual results:

The "->" is translated to "->" (html entity)


Expected results:

I'd expected to see "->" again or even better → (→).

Comment 1

[[:fabrice] Fabrice Desré]

Yan, can you take a look?

Comment 2

[Yan Or]

Matias, I see the code is converting '&' to '&' before saving to storage,
in evernote.js:1066:

  var text = child.nodeValue.replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/&(?!amp;)/g, "&amp;");

Why is this line needed?  The data should already be in HTML, no?

Comment 3

[Masatoshi Kimura [:emk]]

Even if the input is in plain text, the replace order is wrong.
Ampersands must be replaced before any other meta characters:

  var text = child.nodeValue.replace(/&(?!amp;)/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;");

Comment 4

[Matias Crivolotti]

Yan, the replacement was needed after we received a review saying everything is deleted after typing '&' in the note body.

I think that if you change the replace order like Masatoshi suggested it will work fine.

Comment 5

[Yan Or]

Attachment: Pull request

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This doesn't have r+ AFAICT.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://github.com/mozilla-b2g/notes/commit/fb4110face6c98fb56733c28d5dfbae94922c9f2

Comment 8

[Peter Bylenga [:PBylenga]]

I was able to verify this issue as Fixed in the following build with the latest version of Notes app:

v1.3 Environmental Variables:
Device: Buri v1.3 MOZ
BuildID: 20140410004002
Gaia: 62acb4b0e774b6709b8be400d849f807404bb21b
Gecko: 94baf6039462
Version: 28.0
Firmware Version: v1.2-device.cfg