Closed Bug 978937 Opened 12 years ago Closed 12 years ago

Do a better job of disabling Rocketbar

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 959694

People

(Reporter: benfrancis, Assigned: benfrancis)

Details

Right now the Rocketbar still gets initialised even if it's turned off, meaning all the event listeners get added but nothing is displayed on the screen. I figured out I could break 15 unrelated integration tests with a two character change in rocketbar.js for this reason. My idea is to make Rocketbar.init() just add a settings listener, then initialise everything else only when it detects the Rocketbar was enabled in settings. We should also have an uninit which removes all the event listeners if Rocketbar is disabled.
Assignee: nobody → bfrancis
Fixed in bug 959694
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.