978984 - [MADAI][Camera] HUD and recording timer visible at same time

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Justin D'Arcangelo [:justindarc]]

In dmarcos/camera-dev-rebased, the HUD and recording timer are both visible at the same time when recording a video (overlapping). The HUD should not be visible until recording has completed.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request #63 to dmarcos/camera-dev-rebased

Comment 2

[Diego Marcos [:dmarcos]]

Attachment: pull-request (camera-new-features)

Comment 3

[Wilson Page [:wilsonpage]]

Attachment: pull-request (camera-new-features)

Comment 4

[Wilson Page [:wilsonpage]]

Resubmitted with fixed and added unit-tests.

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8386784 [details] [review]
pull-request (camera-new-features)

I don't have any objection to this patch, but I don't understand how it works. I don't see any code to hide the hud when recording starts or to show the hud again when recording ends.  Please double-check that this is actually the full patch that you intended for this bug. 

Also: I'd suggest that it be merged in with 974102 so that we land the video timer functionality all at once.

Comment 6

[Justin D'Arcangelo [:justindarc]]

The View.prototype has show()/hide()/toggle() implemented on it. This patch simply overrides the show() behavior to ensure that recording is not occurring. This is the full patch.

Comment 7

[Diego Marcos [:dmarcos]]

This has been fixed as part of bug 971086 that includes the recording timer as well. I close the bug. The PR attached is strange. I let wilson confirm that we're not missing anything

Comment 8

[Wilson Page [:wilsonpage]]

Yep, looks like we've addressed this already.

Comment 9

[J Zimbrick]

Issue appears fixed on the latest Buri 1.4 and 1.5 builds.

When recording with the camera, all HUD UI except for the stop button and the timer are hidden. 
The HUD reappears when the stop button is tapped and the camera is no longer recording.

1.4 Environmental Variables: 
Device: Buri
BuildID: 20140407000203
Gaia: 86de7fcce674ef6196d68e7e23552d219a3d72db
Gecko: 6e028297be14
Version: 30.0a2
Base Image: V1.2-device.cfg

1.5 Environmental Variables: 
Device: Buri
BuildID: 20140407040202
Gaia: f1a98bfaa3ab2480945bd7018831fd56c61cdc24
Gecko: 5405d6f4e3c6
Version: 31.0a1
Base Image: V1.2-device.cfg