978998 - Change 'Join group' button in 'by request' groups

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[William Reynolds [:williamr]]

To better explain to users looking at a 'by request' group that they must request to join that group, let's change the button text from 'Join group' to 'Request to join group'.

Comment 1

[sraban]

Hi,
 I m interested to work on this bug.

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Hi sraban,

Thanks for offering to help. Please start by setting up your environment. You can find instructions here http://mozillian.rtfd.org. When you're ready ping me to assign a bug to you.

If you have questions you can find us on mozilla IRC in channel #commtools.

Good luck!

Comment 3

[sraban]

Hi Giorgos,
   Actually  http://mozillian.rtfd.org shows a error message that "the page doesn't exist yet". What can i do now?

Comment 4

[Giorgos Logiotatidis [:giorgos]]

My bad, it's 

http://mozillians.rtfd.org

Comment 5

[sraban]

Hi Giorgos,
  I am ready with my environment. Assign this bug to me.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

Good luck!

Comment 7

[Giorgos Logiotatidis [:giorgos]]

Hi sraban,

Any updates on this? If you're stuck you can ping me here or on IRC for help :) If you don't have the time, no problem: I can de-assign you from this bug and give you a new one when you have more free time. Please let me know.

Comment 8

[sraban]

Hi Giorgos,
   Sorry for being inactive in these days.As my exam is going on so i can't give enough time to this bug. :(  You can de-assign it.I'll be free after 25th April.

Comment 9

[Giorgos Logiotatidis [:giorgos]]

No problemo. Please come back when you're done. Good luck with your exams!

Comment 10

[Justin Crawford [:hoosteeno] [:jcrawford]]

:seanh, please ping us in #commtools if you have questions about resolving this bug. Thanks for taking it on!

Comment 11

[seanh]

Pull request here: https://github.com/mozilla/mozillians/pull/891

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/e1d99abd11d3480bc854ff09e5432f8658763d80
[fix bug 978998] Display 'Request to Join Group' for moderated groups.

Comment 13

[Giorgos Logiotatidis [:giorgos]]

Verified on stage:
 - Open groups display 'Join Group'
 - By request group display 'Request to Join Group'

Thanks Sean!