Closed Bug 979018 Opened 10 years ago Closed 10 years ago

[Messages] Background doesn't always scroll with Content

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S3 (14mar)

People

(Reporter: mchang, Assigned: mchang)

Details

(Keywords: perf, Whiteboard: [c=handeye p=1 s= u=])

Attachments

(1 file)

While looking at the layer tree, I notice while scrolling the SMS app, we still sometimes have componentAlpha on the scrollable layer.
Comment on attachment 8384938 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16806

Found a few spots where we were missing an opaque background while scrolling.
Attachment #8384938 - Flags: review?(21)
Big thanks for doing this Mason. It will buy us time until we can have the platform deal with this better.
Comment on attachment 8384938 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16806

Stealing the review, will do it today.

Do we need this on 1.3 as well?
Attachment #8384938 - Flags: review?(21) → review?(felash)
Mason, for the purposes of answering questions in the 1.3 triage, how noticeable/measurable is the improvement?
blocking-b2g: --- → 1.3?
I don't see a very large performance difference for SMS. We're gated by grallocs (see bug 979026). I'm not comfortable landing on 1.3. We did the same thing for calendar and it produced a UX issue. Julien, if you want to manually test to see if there are some graphics issues, that'd be very helpful. I didn't see any, but always good to have another eye.
Can you take another look, I pushed an update. Thanks!
Flags: needinfo?(felash)
Comment on attachment 8384938 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16806

looks good, r=me

I don't understand why we need this in addition to the other rule though...
Attachment #8384938 - Flags: review?(felash) → review+
Flags: needinfo?(felash)
Thanks! Landed in gaia master - a7bffa96123d8cd828ceaea72f888046c6268248
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to Mason Chang [:mchang] from comment #6)
> I don't see a very large performance difference for SMS. We're gated by
> grallocs (see bug 979026). I'm not comfortable landing on 1.3. We did the
> same thing for calendar and it produced a UX issue. Julien, if you want to
> manually test to see if there are some graphics issues, that'd be very
> helpful. I didn't see any, but always good to have another eye.

Moving to non-blocking per this comment.
blocking-b2g: 1.3? → ---
In response to comment 6, I don't expect this would regress anything but we can still come back here later if we find it's necessary.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: