979054 - Try adding toolbar edge padding before customization transition starts, not after.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

We add some padding to the start and end of the toolbar customization targets to make it easier to add things at the start and end of them.

That padding is currently being added at the end of the customize mode transition. Adding it to the beginning should make the transition finish less jarring.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

This... this looks pretty good, I must say. On Windows, anyway.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8387187 [details] [diff] [review]
Patch v1

phlsa likes this, and so do I. I think this makes things a lot smoother.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/c23f0d27769c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c23f0d27769c

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8387187 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Australis!


User impact if declined: 

A slightly jankier customize mode transition - there'll be more of a "bump" when the transition ends.


Testing completed (on m-c, etc.): 

Lots of local testing.


Risk to taking this patch (and alternatives if risky): 

Very low.


String or IDL/UUID changes made by this patch:

None.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c888d74d3963