Closed Bug 979067 Opened 7 years ago Closed 7 years ago

Stop exporting the guard object classes

Categories

(Core :: MFBT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Attachment #8384997 - Flags: review?(nfroyd)
Attachment #8384997 - Flags: review?(nfroyd) → review+
Why this change?  We exported them for a reason, I think to avoid warnings of some sort on some platform.  Hazy memory says glandium was involved.
https://hg.mozilla.org/mozilla-central/rev/260334e5c5aa
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Bug 717540 comment 9 says
"Leaving MFBT_API triggers a warning or a failure to build on windows. I don't remember which one exactly, I've had so many problems with this thing..."

(It was MFBT_API before being MOZ_EXPORT_API then MOZ_EXPORT)

Removing MOZ_EXPORT is not quite the same as replacing with MFBT_API, maybe it's fine. Ehsan, did you check this doesn't add more warnings?
You need to log in before you can comment on or make changes to this bug.