Closed
Bug 979067
Opened 10 years ago
Closed 10 years ago
Stop exporting the guard object classes
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
1.21 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Updated•10 years ago
|
Attachment #8384997 -
Flags: review?(nfroyd)
Updated•10 years ago
|
Attachment #8384997 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/260334e5c5aa
Comment 3•10 years ago
|
||
Why this change? We exported them for a reason, I think to avoid warnings of some sort on some platform. Hazy memory says glandium was involved.
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/260334e5c5aa
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Comment 5•10 years ago
|
||
Bug 717540 comment 9 says "Leaving MFBT_API triggers a warning or a failure to build on windows. I don't remember which one exactly, I've had so many problems with this thing..." (It was MFBT_API before being MOZ_EXPORT_API then MOZ_EXPORT) Removing MOZ_EXPORT is not quite the same as replacing with MFBT_API, maybe it's fine. Ehsan, did you check this doesn't add more warnings?
You need to log in
before you can comment on or make changes to this bug.
Description
•