Closed
Bug 979111
Opened 11 years ago
Closed 11 years ago
Move google analytics into separate file in Thimble
Categories
(Webmaker Graveyard :: Thimble, defect)
Webmaker Graveyard
Thimble
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: admix, Assigned: admix)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.74.9 (KHTML, like Gecko) Version/7.0.2 Safari/537.74.9
Steps to reproduce:
Move google analytics into separate file in Thimble.
https://github.com/mozilla/thimble.webmaker.org/blob/master/views/googleanalytics.html
Expected results:
In order to move closer to CSP implementation, this should be fixed.
|
Assignee | |
Comment 1•11 years ago
|
||
Moved google analytics script into separate js file.
PR -> https://github.com/mozilla/thimble.webmaker.org/pull/372
Attachment #8385088 -
Flags: review?(jon)
|
|
||
Updated•11 years ago
|
Assignee: nobody → admix.snurnikov
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Updated•11 years ago
|
Attachment #8385088 -
Flags: review?(jon) → review+
|
||
Comment 2•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/fc79207011d84f10c8161936aca0c6920c77e08d
[bug979111] - Moved google analytics into separate file
https://github.com/mozilla/thimble.webmaker.org/commit/c041124f8f8e29aa280742a7979bfe7b2a4423d8
Merge pull request #372 from admix/bug979111
[bug979111] - Moved google analytics into separate file
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•