Closed Bug 979122 Opened 12 years ago Closed 11 years ago

Modal "X" close buttons vanish upon focus

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2014-07-29

People

(Reporter: cvan, Assigned: delza)

References

(
URL
)

Details

(Whiteboard: [cosmetic][repoman])

1. Load https://marketplace.firefox.com/app/hype-machine/ratings 2. Click "Write a Review" button for modal to appear. 3. Hold down on the "X" icon in the top right of the modal. 4. Notice the "X" disappears (instead of turning into a different colour). http://f.cl.ly/items/202N2E3S012X373U440D/Screen%20Shot%202014-03-03%20at%207.56.44%20PM.png Same happens for Feedback modal, etc.
Priority: -- → P3
Whiteboard: [cosmetic]
Whiteboard: [cosmetic] → [cosmetic][repoman]
Assignee: nobody → delza
At some point (2014-02-18) we made a rule in /src/media/css/site.styl to make all a:active links. After talking with [:ngo] it looks like this was a workaround for a browser bug on Android that was fixed in FF28, so we should be able to safely remove this rule.
Corrections: Conversation with [:ngoke] determined it should be safe to over-ride this rule locally, not remove it.
Fixed in PR https://github.com/mozilla/fireplace/pull/528
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-07-29
Verified as fixed in marketplace-dev.allizom.org Postfix screencast: http://screencast.com/t/i8IhPOAVeGX Closing.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.