979148 - Support position change notify for IMM32

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Makoto Kato [:m_kato]]

On focusing editbox on scollable content, when I scroll content, candidate window of IME keeps same position.  Position of candidate window should changes by scroll.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: v1

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8385128 [details] [diff] [review]
v1

follow up bug 968647 for IMM32

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8385128 [details] [diff] [review]
v1

If caret position is moved outside of the editor rect, how does this work?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #3)
> Comment on attachment 8385128 [details] [diff] [review]
> v1
> 
> If caret position is moved outside of the editor rect, how does this work?

Candidate window will be out of firefox's window.  Do you think what behavior we should implement this??  Should we keep it just under Firefox's windows?

Comment 5

[Makoto Kato [:m_kato]]

Also on TSF, it depends on TSF.

MS-IME .... screen's left-top.
ATOK (2013) ... out of Firefox window
Google IME ... keep just under Firefox window

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Makoto Kato (:m_kato) from comment #4)
> (In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #3)
> > Comment on attachment 8385128 [details] [diff] [review]
> > v1
> > 
> > If caret position is moved outside of the editor rect, how does this work?
> 
> Candidate window will be out of firefox's window.  Do you think what
> behavior we should implement this??  Should we keep it just under Firefox's
> windows?

I guess that align to window edge is reasonable but I'm not sure. Although, it's not so important because it must be rare case.

(In reply to Makoto Kato (:m_kato) from comment #5)
> Also on TSF, it depends on TSF.
> 
> MS-IME .... screen's left-top.
> ATOK (2013) ... out of Firefox window
> Google IME ... keep just under Firefox window

Yeah, on TSF, TIP decides its candidate window position itself...

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8385128 [details] [diff] [review]
v1

Temporarily, +'ing this patch. I think that we should file a new bug for the remaining issue.

Comment 8

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #7)
> Comment on attachment 8385128 [details] [diff] [review]
> v1
> 
> Temporarily, +'ing this patch. I think that we should file a new bug for the
> remaining issue.

filed as bug 980189

Comment 9

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/407e82dd7c3c

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/407e82dd7c3c