Closed Bug 979205 Opened 7 years ago Closed 7 years ago

[tarako] Change the LMK and low-mem notification trigger preferences to be specified in KiB

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
1.4 S3 (14mar)
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #972130 +++

The preferences used to set LMK levels and the low-memory notification trigger currently take MiB values; this is too coarse for low-memory devices where we want to fine-tune these values further. Changing them to KiB values should provide enough granularity for this task.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Attachment #8385208 - Flags: review?(fabrice)
Attachment #8385208 - Flags: review?(fabrice) → review+
Thanks for the review Fabrice, try is happy, time to check-in:

https://tbpl.mozilla.org/?tree=Try&rev=67f0f3c76b67
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7c72bc31a058
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
blocking-b2g: --- → 1.3T+
Hi James: can you uplift to 1.3T and then ni me again? WIP patch will change after this uplift.
Flags: needinfo?(james.zhang)
Ying will take it.
Flags: needinfo?(james.zhang) → needinfo?(ying.xu)
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/500d42eed558

But to be frankly, I think change MB to KB won't help much.
Flags: needinfo?(ying.xu)
Flags: needinfo?(ttsai)
Thomas, should we change dev-pref.js in device/sprd now ?
Flags: needinfo?(fabrice)
(In reply to James Zhang from comment #8)
> Thomas, should we change dev-pref.js in device/sprd now ?

Yes!
Flags: needinfo?(fabrice)
Flags: needinfo?(ttsai)
Ying, please also help to update the dev-pref.js in device.
https://github.com/Seinlin/tarako-patches/commit/fd2e9e25e04c12c5df5e9a444d44ae0d17e667a2
I will remove the WIP patches if it's landed.
Flags: needinfo?(ying.xu)
(In reply to Danny Liang [:dliang] from comment #10)
> Ying, please also help to update the dev-pref.js in device.
> https://github.com/Seinlin/tarako-patches/commit/
> fd2e9e25e04c12c5df5e9a444d44ae0d17e667a2
> I will remove the WIP patches if it's landed.

done.
Flags: needinfo?(ying.xu)
You need to log in before you can comment on or make changes to this bug.