979225 - Reports Time wrong on Profile page

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Brian King [:kinger]]

Attachment: wqReports.png

NG Reports.

William Q just filed a short time ago a couple of test reports. On this dashboard at https://reps.mozilla.org/u/wquiviger/ the 'Date column' shows the wrong time of creation. It shows 11 hours ago even though they were created less than an hour ago. See screenshot attached.

Comment 1

[Tasos Katsoulas [:tasos]]

This is happening because the report date is a DateField, so when a report is submitted, the date is saved and the time is reverted to midnight. In order to show the submission time, the field should be changed to DateTimeField.

The reason behind this choice was, that a user could file a report either in the past or future, so the time of the submission wasn't considered important. Do you feel that this is something that we need to change?

Comment 2

[William Quiviger [:williamq]]

I think it would be good to have a time stamp for each report filed, regardless of what period the report is covering. 

Brian: what do you think?

Comment 3

[Giorgos Logiotatidis [:giorgos]]

Reports are date based, that's something we've agreed upon and I believe it's good decision. 

When it comes to that bug we just need to alter the way the JS handles hours.

Easiest solution atm is to display date instead of "today", "x hours ago" etc.

Comment 4

[Brian King [:kinger]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #3)
> Easiest solution atm is to display date instead of "today", "x hours ago"
> etc.

That is fine for me.

Comment 5

[William Reynolds [:williamr]]

I agree with comment 3. I don't think there is a great case for storing the time of the report - that was something we considered when choosing the data types for the new reporting system.

I like the idea Giorgos suggested of changing the text we display. I think showing relative time in terms of days/weeks/months works well. For example "Today", "Yesterday", "2 days ago", "1 week ago", "2 months ago".

For the specific case in comment 0, we could simply show the text "Today".

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/b8d4145f079a05e6cd8edf354edfc4103b4aae75
[fix bug 979225] Fix wrong timestamp in ngreport listing in profiles.

https://github.com/mozilla/remo/commit/c06571ba9272727df96add713137d033c4b0a6ae
Merge pull request #656 from akatsoulas/979225

[fix bug 979225] Fix wrong timestamp in ngreport listing in profiles.

Comment 7

[William Reynolds [:williamr]]

Verified on stage. After reporting an activity, the activity is listed on my profile with the date "Today". Nice fix, Tasos!