Closed Bug 979284 Opened 7 years ago Closed 7 years ago

[Camera] Remove picture/video size selection from settings menu


(Firefox OS Graveyard :: Gaia::Camera, defect)

Gonk (Firefox OS)
Not set


(Not tracked)

1.4 S3 (14mar)


(Reporter: wilsonpage, Unassigned)



(1 file)

For simplicity we are removing the ability for users to select picture/video resolition, and instead selecting the following:

- Largest 4:3 picture size
- Largest 16:9 video size
Landed in dmarcos/camera-dev-rebased
Attachment #8385849 - Flags: review?(dflanagan)
Target Milestone: --- → 1.4 S3 (14mar)
Comment on attachment 8385849 [details] [review]
pull-request (camera-new-features)

r- because if I understand correctly, this patch leaves us at the mercy of whatever order the camera driver chooses to list its photo and video size options. 

The initial comment says that this patch selects:

- Largest 4:3 picture size
- Largest 16:9 video size

But actually that only happens if the camera driver lists the largest 4:3 picture size first for both front and back cameras, and the largest 16:9 video size first for both cameras as well.

I'd prefer a patch that explicitly sorted the list of resolutions.  But I'm willing to accept this patch if it comes with a big comment/warning about the assumption being made here.  I'm guessing that Cameracontroller.prototype.onSettingsConfigured is the right place to put such a warning.

Needinfo Wilson since it is his patch but the review request comes from Diego.
Attachment #8385849 - Flags: review?(dflanagan) → review-
Flags: needinfo?(wilsonpage)
Correct, this patch does leave us at the mercy of the order of `camera.capabilities.pictureSizes` if pictureSizes front/back is left unconfigured.

Partners can define supported pictureSizes options, and a `selected` default in js/config/app.js, which allows them to override the default selection logic if they wish. This is exactly the route Madai are taking as they are favouring 16:9 pictureSize as default.
Flags: needinfo?(wilsonpage) → needinfo?(dflanagan)
Okay. Add a comment, at least, before landing.
Flags: needinfo?(dflanagan)
This issue has been resolved as part of Bug 980599.
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.