Closed Bug 979330 Opened 10 years ago Closed 10 years ago

In contacts edit if the type of a field changes in the selection box the done button is enabled

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.4 S3 (14mar)

People

(Reporter: jmcf, Assigned: jmcf)

Details

(Keywords: verifyme)

Attachments

(1 file)

16832.html
191 bytes, text/html
arcturus
: review+
Details 
STR:

Contacts / Add new contact/ Change the type of a field (mobile, address, etc). The done button is enabled. Then, the user can press that button and the app may get stuck on that screen.
Attached file 16832.html — 

        Attachment #8385387 -
        Flags: review?(francisco.jordano)

    
    

    
  
Comment on attachment 8385387 [details]
16832.html

LGTM, relaunched the jobs in travis.

Please merge once is green!
Flags: in-testsuite+

    
    

    
  
Comment on attachment 8385387 [details]
16832.html

Forgot to add the r+!!

Marionette tests are still failing, I just relaunched.

Please merge once they are green.

        Attachment #8385387 -
        Flags: review?(francisco.jordano) → review+

    
    

    
  
landed in master:

https://github.com/mozilla-b2g/gaia/commit/da5e62b57b80aa4f61652ac2008035b66d04d0fb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
  
Keywords: verifyme
Target Milestone: --- → 1.4 S3 (14mar)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: