Closed Bug 979370 Opened 7 years ago Closed 7 years ago

[Bluetooth] Move BT thread into BlueZ backend


(Firefox OS Graveyard :: Bluetooth, defect)

Gonk (Firefox OS)
Not set


(Not tracked)

1.4 S3 (14mar)


(Reporter: tzimmermann, Assigned: tzimmermann)




(4 files, 1 obsolete file)

The BT thread is only necessary for the BlueZ backend. We should remove it from the generic code BluetoothService and move it into BluetoothDBusService.
Attachment #8386719 - Flags: review?(echou)
Comment on attachment 8386717 [details] [diff] [review]
[01] Bug 979370: Move Bluetooth thread into BlueZ backend

Review of attachment 8386717 [details] [diff] [review]:

Looks good to me. This r+ is actually based on that I know other patches will do the cleanup on stuff like removing ToggleBtTask.
Attachment #8386717 - Flags: review?(echou) → review+
Hi Thomas,

Sorry for being a little late. I've been attending media work week this week. I'll find some time to review your patches. :)
Comment on attachment 8386718 [details] [diff] [review]
[02] Bug 979370: Split |BluetoothService::StartStopBluetooth|

Review of attachment 8386718 [details] [diff] [review]:

Looks good.
Attachment #8386718 - Flags: review?(echou) → review+
Comment on attachment 8386719 [details] [diff] [review]
[03] Bug 979370: Remove |ToggleBtTask|

Review of attachment 8386719 [details] [diff] [review]:

r=me with nits picked. Thanks.

::: dom/bluetooth/BluetoothService.cpp
@@ +465,5 @@
>    }
>    mAdapterAddedReceived = false;
> +  /* When IsEnabled() is false, we don't switch on Bluetooth but we still

nit: we don't switch /off/ Bluetooth
Attachment #8386719 - Flags: review?(echou) → review+
Comment on attachment 8386720 [details] [diff] [review]
[04] Bug 979370: Remove |BluetoothService::IsEnabledInternal|

Review of attachment 8386720 [details] [diff] [review]:

Looks good. Thanks.
Attachment #8386720 - Flags: review?(echou) → review+
Changes to v1:

  - fixed comment in |BluetoothService::StopBluetooth|
Attachment #8386719 - Attachment is obsolete: true
Attachment #8391083 - Flags: review+
You need to log in before you can comment on or make changes to this bug.