979373 - Merge Sync Status activity into Fennec Settings on tablet

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Android Sync, defect, P5)

Description

[Ioana Chiorean]

Attachment: Comparison

Build: Beta 28.0b8
Tablet: Asus Eee Transformers - Android 4.0.4
Phone: x86 ZTE -Android 4.0.3

Steps:
1. Go to Settings

Actual Results:
- On phone there is a separate entry - Sync - while on tablet Sync is under Customize entry

Expected results:
- The Entry should be consistent between platforms
- If we consider that the tablet has a bigger surface - we could have sync separate there (will be awkward to enter sync menu 1st time though)

Note: see attached comparison

Comment 1

[Nick Alexander :nalexander [he/him]]

Yep, we expected this to be the case when we landed Bug 974134.  It was a tactical choice to improve the situation on phones.

That ticket landed a new status activity that embeds a status fragment.  It plays much better with the phone layout.  We can follow-up to try to integrate that status fragment into the correct place when in tablet layout.  This is technically tricky, and might require new strings, so we haven't done it yet.

Comment 2

[Nick Alexander :nalexander [he/him]]

The main technical points that I see:

* it's onerous to handle all versions of Android;
* ditto handling different form factors;
* need to configure "preference headers", following Fennec style;
* need to attach StatusFragment in the appropriate places;
* need to ensure that "have account/don't have account" logic is updated.

Comment 3

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.