Closed Bug 979422 Opened 10 years ago Closed 10 years ago

HTTP cache wrapper performs UMR if onCacheEntryCheck fails

Categories

(Core :: Networking: Cache, defect)

Product:
Core
Component:
Networking: Cache
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla31
Tracking Flags:
Tracking Status
firefox31 --- fixed

People

(Reporter: neil, Assigned: mayhemer)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

v1
876 bytes, patch
michal
: review+
mayhemer
: checkin+
Details | Diff | Splinter Review 
If the HTTP cache wrapper needs to perform a cache entry check (e.g. from a call to AsyncOpenURI) then it warns if the check fails, but tries to use the now-uninitialised result.

I discovered this when I had forgotten to implement onCacheEntryCheck and the wrappers ignored my error.

(On an unrelated node, I wonder why anyone would want onCacheEntryCheck to be invoked on the main thread, since it's guaranteed to be followed immediately by onCacheEntryAvailable anyway.)
Assignee: nobody → honzab.moz
Severity: trivial → major
Status: NEW → ASSIGNED
Attached patch v1 — — Splinter Review 
https://tbpl.mozilla.org/?tree=Try&rev=d39cf82c7f2e
Attachment #8386140 - Flags: review?(michal.novotny)
Attachment #8386140 - Flags: review?(michal.novotny) → review+
https://hg.mozilla.org/mozilla-central/rev/042679e999a7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
status-firefox31: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: