97944 - build venkman by default

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Robert Ginda]

we need to build venkman by default on mac/win/linux.

Comment 1

[Robert Ginda]

Attachment: linux, mac, and windows changes to build system

Comment 2

[Robert Ginda]

The attached patch makes Venkman part of the default build on Mac and Windows. 
On Linux, the binary portion is build by default, but the front end is still an
option.

On Linux:
Now that jsd is built by default, the --disable-jsd option turns into
--enable-jsd.  You still need --with-extensions=default,venkman to get the front
end.

On Windows:
Both front end and jsd built by default, set DISABLE_JSD to prevent it from
being built.

On Mac:
set jsdebugger 0

r/sr=?

Comment 3

[Robert Ginda]

Attachment: new patch

Comment 4

[Robert Ginda]

New patch builds UI by default on linux too, and includes the changes to
extensions/makefile.win.

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 50757 [details] [diff] [review]
new patch

sr=shaver

Comment 6

[Robert Ginda]

Thanks, someone wanna r=?

Comment 7

[hacker formerly known as [e-mail]]

Why disable venkman on win32 if jsd is disabled?  I thought they were supposed
to be separate?  

Comment 8

[Robert Ginda]

Attachment: another new patch; seperate venkman and jsd options on mac and windows

Comment 9

[Robert Ginda]

To be clear, venkman was (and still is) tied to jsd on all three platforms.  You
can not (and could not) build venkman without building jsd.  With the new patch,
you can now build *jsd* without *venkman* on all three platforms.  This was
previously only possible on unix.

Comment 10

[hacker formerly known as [e-mail]]

Comment on attachment 51378 [details] [diff] [review]
another new patch; seperate venkman and jsd options on mac and windows

r=cls

Comment 11

[Peter Van der Beken [:peterv]]

Comment on attachment 51378 [details] [diff] [review]
another new patch; seperate venkman and jsd options on mac and windows

r=peterv.

Comment 12

[Robert Ginda]

Checked in.

Comment 13

[Robert Ginda]

Reopening.  The mac project file doesn't seem to like opt mode.  I've turned off
the jsd and venkman options for now.

Comment 14

[jag (Peter Annema)]

Checked in a mac project file that seemed to work for me. Updated the Mac build 
flags to build venkman. Marking bug fixed.

Comment 15

[Robert Ginda]

Thanks jag!

Comment 16

[sk]

I 've just installed build 2001100103 which according to mozillazine should have
this javascript debugger built in, but I cant see anything on tasks->tools

Comment 17

[Robert Ginda]

MozillaZine is wrong.  Fixing this bug made Venkman build by default, but this
alone does not get Venkman into installer builds.  See bug 97945.

In the meantime, Venkman *is* in non-installer builds.

Comment 18

[Axel Hecht]

reopening. --enable-jsd disables jsd. :-(

micro patchlet coming up.

Axel

Comment 19

[Axel Hecht]

Attachment: MOZ_ARG_ENABLE_BOOL should be MOZ_ARG_DISABLE_BOOL

Comment 20

[hacker formerly known as [e-mail]]

Comment on attachment 53081 [details] [diff] [review]
MOZ_ARG_ENABLE_BOOL should be MOZ_ARG_DISABLE_BOOL

r=cls

Comment 21

[Asa Dotzler [:asa]]

0.9.5 is out the door. bumping TM up by one.

Comment 22

[Robert Ginda]

This was checked in as configure.in 1.916

Comment 23

[Christopher Aillon (sabbatical, not receiving bugmail)]

Yep, this is definitely fixed.  Verified