Closed
Bug 97944
Opened 23 years ago
Closed 23 years ago
build venkman by default
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.6
People
(Reporter: rginda, Assigned: rginda)
References
Details
Attachments
(2 files, 2 obsolete files)
4.78 KB,
patch
|
netscape
:
review+
|
Details | Diff | Splinter Review |
449 bytes,
patch
|
netscape
:
review+
|
Details | Diff | Splinter Review |
we need to build venkman by default on mac/win/linux.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
The attached patch makes Venkman part of the default build on Mac and Windows. On Linux, the binary portion is build by default, but the front end is still an option. On Linux: Now that jsd is built by default, the --disable-jsd option turns into --enable-jsd. You still need --with-extensions=default,venkman to get the front end. On Windows: Both front end and jsd built by default, set DISABLE_JSD to prevent it from being built. On Mac: set jsdebugger 0 r/sr=?
Assignee | ||
Updated•23 years ago
|
Attachment #50746 -
Attachment is obsolete: true
Assignee | ||
Comment 3•23 years ago
|
||
Assignee | ||
Comment 4•23 years ago
|
||
New patch builds UI by default on linux too, and includes the changes to extensions/makefile.win.
Comment on attachment 50757 [details] [diff] [review] new patch sr=shaver
Attachment #50757 -
Flags: superreview+
Assignee | ||
Comment 6•23 years ago
|
||
Thanks, someone wanna r=?
Comment 7•23 years ago
|
||
Why disable venkman on win32 if jsd is disabled? I thought they were supposed to be separate?
Assignee | ||
Comment 8•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Attachment #50757 -
Attachment is obsolete: true
Assignee | ||
Comment 9•23 years ago
|
||
To be clear, venkman was (and still is) tied to jsd on all three platforms. You can not (and could not) build venkman without building jsd. With the new patch, you can now build *jsd* without *venkman* on all three platforms. This was previously only possible on unix.
Comment 10•23 years ago
|
||
Comment on attachment 51378 [details] [diff] [review] another new patch; seperate venkman and jsd options on mac and windows r=cls
Attachment #51378 -
Flags: review+
Comment 11•23 years ago
|
||
Comment on attachment 51378 [details] [diff] [review] another new patch; seperate venkman and jsd options on mac and windows r=peterv.
Assignee | ||
Comment 12•23 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 13•23 years ago
|
||
Reopening. The mac project file doesn't seem to like opt mode. I've turned off the jsd and venkman options for now.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 14•23 years ago
|
||
Checked in a mac project file that seemed to work for me. Updated the Mac build flags to build venkman. Marking bug fixed.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•23 years ago
|
||
Thanks jag!
Comment 16•23 years ago
|
||
I 've just installed build 2001100103 which according to mozillazine should have this javascript debugger built in, but I cant see anything on tasks->tools
Assignee | ||
Comment 17•23 years ago
|
||
MozillaZine is wrong. Fixing this bug made Venkman build by default, but this alone does not get Venkman into installer builds. See bug 97945. In the meantime, Venkman *is* in non-installer builds.
Comment 18•23 years ago
|
||
reopening. --enable-jsd disables jsd. :-( micro patchlet coming up. Axel
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 19•23 years ago
|
||
Comment 20•23 years ago
|
||
Comment on attachment 53081 [details] [diff] [review] MOZ_ARG_ENABLE_BOOL should be MOZ_ARG_DISABLE_BOOL r=cls
Attachment #53081 -
Flags: review+
Comment 21•23 years ago
|
||
0.9.5 is out the door. bumping TM up by one.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Assignee | ||
Comment 22•23 years ago
|
||
This was checked in as configure.in 1.916
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 23•23 years ago
|
||
Yep, this is definitely fixed. Verified
Status: RESOLVED → VERIFIED
QA Contact: rginda → caillon
Updated•20 years ago
|
Product: Core → Other Applications
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•