venkman install packaging

VERIFIED FIXED in mozilla0.9.5

Status

VERIFIED FIXED
17 years ago
12 years ago

People

(Reporter: rginda, Assigned: rginda)

Tracking

Trunk
mozilla0.9.5
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

17 years ago
need to create packaging info for venkman once it gets built by default.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Depends on: 97944
Target Milestone: --- → mozilla0.9.5
(Assignee)

Comment 1

17 years ago
Created attachment 51047 [details] [diff] [review]
changes to packaging related files
(Assignee)

Comment 2

17 years ago
Patch adds debugger service (the binary stuff) to browser.xpi, and adds a
venkman.xpi for the front end, on Linux, Mac, and Windows.  I've tested it on
Linux, and can probably get windows tested soon enough, but help testing windows
or mac would me buch appreciated.
(Assignee)

Comment 3

17 years ago
Created attachment 51147 [details]
/xpinstall/packager/windows/venkman.jst; new file
(Assignee)

Comment 4

17 years ago
Created attachment 51148 [details]
xpinstall/packager/unix/venkman.jst; new file
(Assignee)

Comment 5

17 years ago
Created attachment 51149 [details]
xpinstall/packager/mac/venkman.jst

Updated

17 years ago
Attachment #51047 - Flags: review+

Updated

17 years ago
Attachment #51147 - Flags: review+

Updated

17 years ago
Attachment #51148 - Flags: review+

Updated

17 years ago
Attachment #51149 - Flags: review+

Comment 6

17 years ago
You will need to talk to JJ regarding on how to update the mac installer build 
to recognize the new .xpi file.  Adding JJ to the CC: list.
(Assignee)

Comment 7

17 years ago
I just tested this on windows and all seems fine.

Comment 8

17 years ago
process on the mac is the same as other platforms:

1. make sure the desired files are exported under dist as part of the standard
build (for mac, check build/mac/build_scripts/MozillaBuildList.pm)
2. add the new xpi and its content to "packages-mac" -> done
3. create the install.js template for the new xpi (.jst) -> done4. update the
config.ini template (xpinstall/wizard/mac/macbuild/config.ini_tmpl) with the
appropriate section to handle the new installer module.

Based on the patches already submitted, only the last step is missing for mac.
(Assignee)

Comment 9

17 years ago
I added a [Venkman] section to config.ini_tmpl (well, [Component8]), and
referenced it in the custom install.  See the bottom of the first attachment.

Is there some list of .xpi's to make that is missed?  On unix and windows,
makeall.pl does this job, but I can't locate anything like it for the mac.
(Assignee)

Updated

17 years ago
Blocks: 102292
(Assignee)

Comment 10

17 years ago
JJ, can you explain your comment?  I don't understand what I'm missing here.

Comment 11

17 years ago
Robert,
On all platforms, the installer wizard relies a file named 'config.ini' to know
which modules to install as part of minimum/recommended/custom install options,
as well as some module data to be displayed on the custom install screen.
For your package to be included in either or all of the install options, it must
be declared in the config.ini
On Mac, you need to edit  xpinstall/wizard/mac/macbuild/config.ini_tmpl
and add a "section" describing the new installer module. Use an existing section
as a starting point.

Does this answer your question?

I'm surprised you didn't have to do this for Win32 & Linux which use the same model.
(Assignee)

Comment 12

17 years ago
I did, and I have, for all three platforms.  Look at the bottom of the first
attachment to this bug.  It contains my changes to config.ini_tmpl for the mac.

On windows and linux, I also had to add a line to makeall.pl, which is
responsible for creating all these xpi files in the first place.  (Important
distinction, *create* the xpi file, not *install*.)  I saw no such file on the
mac.  Is config.ini[_tmpl] used ot figure out which .xpi files to make as well?
 If so, I think this patch is ready to be checked in.
(Assignee)

Comment 13

17 years ago
JJ, I'd like to get this checked in for 0.9.5 (tonight!), can you please clarify
your comments.  If you look at the first attachment, you'll see I *already* did
what you're saying I didn't do.  Please advise.

Comment 14

17 years ago
ok. if you did, then we're all clear. I guess i missed the last section of your
initial patch. Sorry for the confusion, you're ahead of me!

Comment 15

17 years ago
To answer your question:
> Is there some list of .xpi's to make that is missed?  On unix and windows,
> makeall.pl does this job, but I can't locate anything like it for the mac.

No, the mac automation relies on the content of packages-mac to determine the
xpi files to create. No other update is required besides the one you already did.

r=jj for the mac changes
Comment on attachment 51047 [details] [diff] [review]
changes to packaging related files

sr=shaver
Attachment #51047 - Flags: superreview+
Comment on attachment 51147 [details]
/xpinstall/packager/windows/venkman.jst; new file

sr=shaver
Attachment #51147 - Flags: superreview+
Comment on attachment 51148 [details]
xpinstall/packager/unix/venkman.jst; new file

sr=shaver
Attachment #51148 - Flags: superreview+
Comment on attachment 51149 [details]
xpinstall/packager/mac/venkman.jst

sr=shaver
Attachment #51149 - Flags: superreview+
(Assignee)

Comment 20

17 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 21

17 years ago
Index: config.it
===================================================================
RCS file: /cvsroot/mozilla/xpinstall/packager/unix/config.it,v
retrieving revision 1.17
diff -u -r1.17 config.it
--- config.it   2001/10/02 23:54:46     1.17
+++ config.it   2001/10/13 08:24:24
@@ -191,7 +191,7 @@
 [Component9]
 Description Short=Debugger
 ; *** LOCALIZE ME BABY ***
-Description Long=JavaScrpt Debugger
+Description Long=JavaScript Debugger
 Archive=venkman.xpi
 $InstallSize$:venkman
 $InstallSizeArchive$:venkman.xpi
[rginda_l@thinkpad unix]$ 
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 22

17 years ago
r= on the above spelling change
(Assignee)

Comment 23

17 years ago
Checked in again.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
Verify fixed.
Status: RESOLVED → VERIFIED
QA Contact: rginda → caillon
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.