7.23 KB, patch
|Details | Diff | Splinter Review|
839 bytes, text/plain
1.02 KB, text/plain
1009 bytes, text/plain
need to create packaging info for venkman once it gets built by default.
Status: NEW → ASSIGNED
Depends on: 97944
Target Milestone: --- → mozilla0.9.5
Patch adds debugger service (the binary stuff) to browser.xpi, and adds a venkman.xpi for the front end, on Linux, Mac, and Windows. I've tested it on Linux, and can probably get windows tested soon enough, but help testing windows or mac would me buch appreciated.
You will need to talk to JJ regarding on how to update the mac installer build to recognize the new .xpi file. Adding JJ to the CC: list.
I just tested this on windows and all seems fine.
process on the mac is the same as other platforms: 1. make sure the desired files are exported under dist as part of the standard build (for mac, check build/mac/build_scripts/MozillaBuildList.pm) 2. add the new xpi and its content to "packages-mac" -> done 3. create the install.js template for the new xpi (.jst) -> done4. update the config.ini template (xpinstall/wizard/mac/macbuild/config.ini_tmpl) with the appropriate section to handle the new installer module. Based on the patches already submitted, only the last step is missing for mac.
I added a [Venkman] section to config.ini_tmpl (well, [Component8]), and referenced it in the custom install. See the bottom of the first attachment. Is there some list of .xpi's to make that is missed? On unix and windows, makeall.pl does this job, but I can't locate anything like it for the mac.
JJ, can you explain your comment? I don't understand what I'm missing here.
Robert, On all platforms, the installer wizard relies a file named 'config.ini' to know which modules to install as part of minimum/recommended/custom install options, as well as some module data to be displayed on the custom install screen. For your package to be included in either or all of the install options, it must be declared in the config.ini On Mac, you need to edit xpinstall/wizard/mac/macbuild/config.ini_tmpl and add a "section" describing the new installer module. Use an existing section as a starting point. Does this answer your question? I'm surprised you didn't have to do this for Win32 & Linux which use the same model.
I did, and I have, for all three platforms. Look at the bottom of the first attachment to this bug. It contains my changes to config.ini_tmpl for the mac. On windows and linux, I also had to add a line to makeall.pl, which is responsible for creating all these xpi files in the first place. (Important distinction, *create* the xpi file, not *install*.) I saw no such file on the mac. Is config.ini[_tmpl] used ot figure out which .xpi files to make as well? If so, I think this patch is ready to be checked in.
JJ, I'd like to get this checked in for 0.9.5 (tonight!), can you please clarify your comments. If you look at the first attachment, you'll see I *already* did what you're saying I didn't do. Please advise.
ok. if you did, then we're all clear. I guess i missed the last section of your initial patch. Sorry for the confusion, you're ahead of me!
To answer your question: > Is there some list of .xpi's to make that is missed? On unix and windows, > makeall.pl does this job, but I can't locate anything like it for the mac. No, the mac automation relies on the content of packages-mac to determine the xpi files to create. No other update is required besides the one you already did. r=jj for the mac changes
Comment on attachment 51047 [details] [diff] [review] changes to packaging related files sr=shaver
Attachment #51047 - Flags: superreview+
Comment on attachment 51147 [details] /xpinstall/packager/windows/venkman.jst; new file sr=shaver
Attachment #51147 - Flags: superreview+
Comment on attachment 51148 [details] xpinstall/packager/unix/venkman.jst; new file sr=shaver
Attachment #51148 - Flags: superreview+
Comment on attachment 51149 [details] xpinstall/packager/mac/venkman.jst sr=shaver
Attachment #51149 - Flags: superreview+
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
r= on the above spelling change
Checked in again.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago → 17 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
QA Contact: rginda → caillon
You need to log in before you can comment on or make changes to this bug.