Closed Bug 979483 Opened 6 years ago Closed 6 years ago

[browser] - Update header design to accommodate larger back-button

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(7 files)

No description provided.
No longer blocks: 968483
Depends on: 979473, 979478
Attached file patch for Gaia/master
Have in mind that this patch depends on bug 979473 and bug 979478
Comment on attachment 8385518 [details] [review]
patch for Gaia/master

Ben, please review for the impact on Browser or reassign as appropriate. Thanks!
Attachment #8385518 - Flags: review?(bfrancis)
Comment on attachment 8385518 [details] [review]
patch for Gaia/master

Sorry Pavel, but this patch causes CSS regressions with the "Done" button (see attached screenshots).

The Travis build errored but I've restarted it and it's looking better now.
Attachment #8385518 - Flags: review?(bfrancis) → review-
Comment on attachment 8385518 [details] [review]
patch for Gaia/master

Hey Ben,

sorry and thanks for the catch ... I fixed the problem hope everything work fine now
Attachment #8385518 - Flags: review- → review?(bfrancis)
Hi Pavel,

What did you change? I'm still seeing the same problems :(
Hey Ben,

I missed to add class="active" to line:
https://github.com/mozilla-b2g/gaia/pull/16841/files#diff-1f492ed606b7934b021f09516102ef5fR272

and everything work OK to me I will add a shots
we don't need to change the markup anymore
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Attachment #8385518 - Flags: review?(bfrancis)
You need to log in before you can comment on or make changes to this bug.