979483 - [browser] - Update header design to accommodate larger back-button

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Browser, defect)

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Have in mind that this patch depends on bug 979473 and bug 979478

Comment 2

[Stephany Wilkes]

Comment on attachment 8385518 [details] [review]
patch for Gaia/master

Ben, please review for the impact on Browser or reassign as appropriate. Thanks!

Comment 3

[Ben Francis [:benfrancis]]

Attachment: CSS bug in Settings app

Comment 4

[Ben Francis [:benfrancis]]

Attachment: CSS bug in bookmark entry sheet

Comment 5

[Ben Francis [:benfrancis]]

Attachment: CSS bug in HTTP authentication dialog

Comment 6

[Ben Francis [:benfrancis]]

Comment on attachment 8385518 [details] [review]
patch for Gaia/master

Sorry Pavel, but this patch causes CSS regressions with the "Done" button (see attached screenshots).

The Travis build errored but I've restarted it and it's looking better now.

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8385518 [details] [review]
patch for Gaia/master

Hey Ben,

sorry and thanks for the catch ... I fixed the problem hope everything work fine now

Comment 8

[Ben Francis [:benfrancis]]

Hi Pavel,

What did you change? I'm still seeing the same problems :(

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Ben,

I missed to add class="active" to line:
https://github.com/mozilla-b2g/gaia/pull/16841/files#diff-1f492ed606b7934b021f09516102ef5fR272

and everything work OK to me I will add a shots

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: shot in Settings app

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Screen Shot 2014-03-06 at 21.43.08.png

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: shot in HTTP authentication dialog

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

we don't need to change the markup anymore