Closed Bug 979488 Opened 6 years ago Closed 6 years ago

[clock] - Update header design to accommodate larger back-button

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(1 obsolete file)

No description provided.
Attached file patch for Gaia/master (obsolete) —
Have in mind that this patch depends on bug 979473 and bug 979478
Comment on attachment 8385525 [details] [review]
patch for Gaia/master

Please review for the impact on Clock or reassign as appropriate. Thanks!
Attachment #8385525 - Flags: review?(gnarf37)
Comment on attachment 8385525 [details] [review]
patch for Gaia/master

I checked this out with the two dependent PRs. The only Clock screen where this matters is the "new/edit alarm" screen. Everything looks OK to me, so r=mcav conditional on landing this after the other two dependent bugs.

I'm a huge fan of the square back buttons, so I'm excited to see this going everywhere :)
Attachment #8385525 - Flags: review?(gnarf37) → review+
we don't need to change the markup anymore
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Attachment #8385525 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.