Closed Bug 979491 Opened 6 years ago Closed 6 years ago

[contacts] - Update header design to accommodate larger back-button

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(2 obsolete files)

No description provided.
Attached file patch for Gaia/master (obsolete) —
Have in mind that this patch depends on bug 979473 and bug 979478
Component: Gaia::Bluetooth File Transfer → Gaia::Contacts
Comment on attachment 8385527 [details] [review]
patch for Gaia/master

Jose, please review for the impact on Contacts or reassign as appropriate. Thanks!
Attachment #8385527 - Flags: review?(jmcf)
Stephany,

It seems this bug depends on two other bugs which have not landed yet. That may be the reason why the app seems to be broken when your patch is applied. See captured screenshot

I'm cancelling the review until that issue is clarified

thanks!
Attached image 2014-03-06-09-34-14.png (obsolete) —
contacts is broken when patch applied
Attachment #8385527 - Flags: review?(jmcf)
Hey Jose,
can you test the patch with patches from Bug 979473 and Bug 979478 ... because we should land all of the bugs together.
Flags: needinfo?(jmcf)
we don't need to change the markup anymore
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
I have just talked to Arnau and he said you are pursuing another solution for bug 979473, so I will keep this PR on hold until that bug is up and landing. 

thanks
Flags: needinfo?(jmcf)
Attachment #8385527 - Attachment is obsolete: true
Attachment #8386615 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.