979525 - Consider having XPCJSContextStack::Push always JS_SaveFrameChain on the JSContext

Status: RESOLVED WONTFIX

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now it does not if the context is already stack-top and the principals match up right...  We're working around that in ~CallSetup by doing manual JS_SaveFrameChain calls.

Comment 1

[Bobby Holley (:bholley)]

I think we can do this when we land these two deps.

Comment 2

[Bobby Holley (:bholley)]

(And we should remember to cleanup the XXX bits added in bug 978618).

Comment 3

[Luke Wagner [:luke]]

Same question here as in bug 960820 comment 6.  If we are mostly iterating with GO_THROUGH_SAVED, what does JS_SaveFrameChain still mean?  Also, since we *also* have HideScriptedCaller, do we need both?

Comment 4

[Bobby Holley (:bholley)]

(In reply to Luke Wagner [:luke] from comment #3)
> Same question here as in bug 960820 comment 6.  If we are mostly iterating
> with GO_THROUGH_SAVED, what does JS_SaveFrameChain still mean?  Also, since
> we *also* have HideScriptedCaller, do we need both?

I will answer in that bug. It's been on my list, but I haven't had time. It's complicated.

Comment 5

[Bobby Holley (:bholley)]

WONTFIXing this in favor of bug 979730. I have patches for this, which I'll keep around in a branch for now (exnstack_gothroughsaved).

Comment 6

[Bobby Holley (:bholley)]

(In reply to Bobby Holley (:bholley) from comment #5)
> WONTFIXing this in favor of bug 979730. I have patches for this, which I'll
> keep around in a branch for now (exnstack_gothroughsaved).

Actually make that https://github.com/bholley/gecko-dev/tree/always_save_frame_chain .

Comment 7

[Bobby Holley (:bholley)]

Attachment: patches.zip

Attaching those patches here to make sure they're archived for posterity.