Closed Bug 979526 Opened 6 years ago Closed 6 years ago

[sms] - Update header design to accommodate larger back-button

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(1 obsolete file)

No description provided.
Attached file patch for Gaia/master (obsolete) —
Have in mind that this patch depends on bug 979473 and bug 979478
Comment on attachment 8385569 [details] [review]
patch for Gaia/master

Kaze, please review for Comms implications, or reassign as necessary to someone who can. Thank you!
Attachment #8385569 - Flags: review?(kaze)
As I wrote for bug 979502, this patch looks good but it can’t be properly reviewed until its two dependencies get r+’ed — see bug 979473 and bug 979478 (and I’m not OK with these two patches at the moment).

Please r? Julien when these two dependencies are ready to land in the shared style folder. Thanks!
Comment on attachment 8385569 [details] [review]
patch for Gaia/master

Julien, can you review this when the two dependencies get r+’ed?
Attachment #8385569 - Flags: review?(kaze) → review?(felash)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Pavel, you should provide comments when you close bugs like this, because now I don't know what I should do.
Flags: needinfo?(pivanov)
Ah sorry I missed the comment on this one.

we don't need to change the markup anymore
Flags: needinfo?(pivanov)
Comment on attachment 8385569 [details] [review]
patch for Gaia/master

removing the review request then

thanks!
Attachment #8385569 - Attachment is obsolete: true
Attachment #8385569 - Flags: review?(felash)
You need to log in before you can comment on or make changes to this bug.