Closed Bug 979533 Opened 6 years ago Closed 6 years ago

[wappush] - Update header design to accommodate larger back-button

Categories

(Firefox OS Graveyard :: Gaia::Wappush, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(1 obsolete file)

No description provided.
Attached file patch for Gaia/master (obsolete) —
Have in mind that this patch depends on bug 979473 and bug 979478
Comment on attachment 8385578 [details] [review]
patch for Gaia/master

Marco, please review for WAP Push implications, or reassign as necessary to someone who can. Thank you!
Attachment #8385578 - Flags: review?(mchen)
Hi,

I think you set to wrong people for the review. Thanks.
Comment on attachment 8385578 [details] [review]
patch for Gaia/master

I'm the owner of the wappush component, taking this, I'll review the patch ASAP.
Attachment #8385578 - Flags: review?(mchen) → review?(gsvelto)
Comment on attachment 8385578 [details] [review]
patch for Gaia/master

I've tested this with the dependent patches applied and it's looking good. The only thing that doesn't look right and for which I'm not giving an r+ right away is that the title appears to be centered now instead of left justified. I'm not sure if this was an intentional design change or not; if it was then ask for review again and I'll r+ the PR, otherwise that issue should be addressed.
Attachment #8385578 - Flags: review?(gsvelto)
Thanks, Gabriele. Appreciate it very much!
Casey and/or Pavel, please address Gabriele's comment #5 so we can move this bug forward.
Flags: needinfo?(pivanov)
Flags: needinfo?(kyee)
Comment on attachment 8385578 [details] [review]
patch for Gaia/master

Hey Gabriele,

Yep, the title is on the right place ... is align to the center of the available space between right edge of the screen and the button (UX spec) for v1.4
Attachment #8385578 - Flags: review?(gsvelto)
Flags: needinfo?(pivanov)
Comment on attachment 8385578 [details] [review]
patch for Gaia/master

Thanks for the info, this LGTM then.
Attachment #8385578 - Flags: review?(gsvelto) → review+
we don't need to change the markup anymore
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Attachment #8385578 - Attachment is obsolete: true
Flags: needinfo?(caseyyee.ca)
You need to log in before you can comment on or make changes to this bug.