979556 - Make ReplaceChar take a UTF-16 array

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Simon Montagu :smontagu]

See bug 847242 comment 4:

>> +  for (uint32_t i = 0; i < ArrayLength(kSeparators); ++i) {
>> +    aBpd->mBuffer.ReplaceChar(kSeparators[i], kSpace);
>
>This doesn't seem efficient. Let's make ReplaceChar work with a UTF16 array >instead.

Comment 1

[Simon Montagu :smontagu]

Attachment: Add new version of ReplaceChar

Comment 2

[Simon Montagu :smontagu]

Attachment: Convert caller

An existing call site using the same pattern as my patch.

Comment 3

[Benjamin Smedberg]

Comment on attachment 8385612 [details] [diff] [review]
Convert caller

Don't you have to null-terminate unsafeBidiCharacters now?

Comment 4

[Simon Montagu :smontagu]

Attachment: Convert caller v.2

Comment 5

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc13389afbe5
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3005bbf540f

Marking in-testsuite+ because this is effectively covered by uriloader/exthandler/tests/mochitest/test_unsafeBidiChars.xhtml

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc13389afbe5
https://hg.mozilla.org/mozilla-central/rev/d3005bbf540f