979632 - [OS X] Replace with menu button graphic with the Australis one.

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

The current menu button we're using on OS X isn't consistent with Australis, but the bigger problem is with the @2x graphic. Our current graphic is very small while on a retina display, the Australis graphic fixes that.

We may want to replace the graphic on other platforms as well, but let's start with OS X.

Comment 1

[Josiah Bruner [:jsbruner]]

Comment on attachment 8385728 [details] [diff] [review]
Patch.

Review of attachment 8385728 [details] [diff] [review]:
-----------------------------------------------------------------

I've already looked at this on both a retina and non-retina display, and everything looks fine, but since we need a reviewer...

Richard, could you look this over real quick?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8385728 [details] [diff] [review]
Patch.

LGTM, thanks Josiah.

Comment 3

[Josiah Bruner [:jsbruner]]

Thanks!

https://hg.mozilla.org/comm-central/rev/8379d4db7c8b

Comment 4

[Richard Marti (:Paenglab)]

Hmm, to late. I planned to propose to optimize the images. I was able to shrink them to 72% and 75% of the actual size.

Comment 5

[Josiah Bruner [:jsbruner]]

I went ahead and landed an optimization patch which reduced the file sizes to 16KB and 43KB as opposed to the previous 21KB and 57KB.

https://hg.mozilla.org/comm-central/rev/0264d503ecc7

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Were there plans to update the Windows and Linux menu buttons as well?

Comment 7

[Josiah Bruner [:jsbruner]]

Yes. But I can't test Windows myself.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

(In reply to Josiah Bruner [:JosiahOne] from comment #7)
> Yes. But I can't test Windows myself.

I can test it for you, or Paenglab can. Would you mind filing bugs for those other systems?

Comment 9

[Josiah Bruner [:jsbruner]]

Sure. Bug 980491.