979637 - Pass URLs for profile, account settings, and /me with user data from login server

Status: RESOLVED INCOMPLETE

(Webmaker Graveyard :: Login, defect)

Description

[inactivate account for kate]

Right now all our apps have to store config settings for the location of profile, accounts, and /me, which is crappy and prone to errors.

Let's return those URLs with user data in webmaker-auth-client

Comment 1

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker-auth/pull/7

Comment 2

[inactivate account for kate]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/243

Comment 3

[Chris DeCairos (:cade)]

Comment on attachment 8386203 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/243

r+ as is - if you want to generate the url object per request, put it back on me for a look when it's ready.

Comment 4

[inactivate account for kate]

Comment on attachment 8386203 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/243

Actually I forgot this is actually supposed to be middleware, oops

Comment 5

[Chris DeCairos (:cade)]

Comment on attachment 8386203 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/243

If we get to this point [1] in the middleware stack, we're guaranteed to have a user object, are we not?

[1]: https://github.com/mozilla/login.webmaker.org/pull/243/files#diff-7ba4e4b2917363abb7bc800f6e9413c6R11

also, why isn't github letting me comment on that diff :/

Comment 6

[Chris DeCairos (:cade)]

I wonder if you should check for the existence of the profile env valu before adding it to the response. For the time being Profile is technically supposed to be disabled on prod. but it might not hurt to have it in there anyways.

Comment 7

[Chris DeCairos (:cade)]

Comment on attachment 8386203 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/243

see comment above ^^

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/8b017303ecbc4f344f55406b3fb6a73eabe78dd5
bug979637 - pass URLs with user object

Comment 9

[inactivate account for kate]

Ok, added the check for profile in

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/ed182f6f586c580c751940b5b6d4979a60e3110f
Revert "bug979637 - pass URLs with user object"

This reverts commit 8b017303ecbc4f344f55406b3fb6a73eabe78dd5.

Comment 11

[Jon Buckley [:jbuck]]

Kate and I decided to back out these two patches after seeing several problems:

- The webmaker-auth patch did not store the URLs in the users session, meaning they'd only be present the first time they logged in, and never after
- Users who logged in before this patch would not have URLs present in their session cookies, with no way to update them. Since the auth cookies are valid for a year, we'd need to wait awhile for everyone to get updated data. Plus, we should probably figure out a way to update data (check if cookie is older than x time period, refresh it on /verify ?)

Comment 12

[Chris DeCairos (:cade)]

I'm closing this bug as part of the planned deprecation of the Webmaker component on Bugzilla.

If this issue is still in need of fixing, you can file it on Github, where we track login related issues for Thimble.

https://github.com/mozilla/login.webmaker.org
https://github.com/mozilla/id.webmaker.org