979642 - Move inline "publish button" script into separate js file

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Alexander [:admix]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.74.9 (KHTML, like Gecko) Version/7.0.2 Safari/537.74.9

Steps to reproduce:

Move this script https://github.com/mozilla/thimble.webmaker.org/blob/master/views/ssooverride.html into separate js file in order to come closer to CSP implementation. Also https://github.com/mozilla/thimble.webmaker.org/blob/master/views/index.html#L8  put linked script with new js file instead of "include"

Comment 1

[Alexander [:admix]]

I can start work on that once it is confirmed. Thanks.

Comment 2

[Alexander [:admix]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/379

Moved inline togetherToggle and disableWebRTC scripts into separate files.
PR -> https://github.com/mozilla/thimble.webmaker.org/pull/379

Comment 3

[Jon Buckley [:jbuck]]

Comment on attachment 8385833 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/379

one nit to fix up in the PR, and this should be good to go

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/437d27507063b0e3e6b51ac9131893a5cf5f6aaf
[bug979642] - Moved inline together toggle script into separate file

[bug979642] - Removed 'async',removed function closure and change file name to together-toggle-script

[bug979642] - Small path fix

[bug979642] - Removed useless comment

[bug979642] - Fixed alignment

https://github.com/mozilla/thimble.webmaker.org/commit/5685dfe59adf4a750eef49ebb82ae30184437ebb
Merge pull request #379 from admix/bug979642

[bug979642] - Moved inline together toggle script into separate file

Comment 5

[Alexander [:admix]]

Actually, I misspelled the bug name, this PR refers to this -> https://bugzilla.mozilla.org/show_bug.cgi?id=979648.
Sorry about that.

Comment 6

[Alexander [:admix]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/382

Sorry for my mess, I accidentally misspelled the branch name and put the attachment for the wrong bug here. previous attachment belongs to this bug ->https://bugzilla.mozilla.org/show_bug.cgi?id=979648

This attachment is correct.
Please review.
PR -> https://github.com/mozilla/thimble.webmaker.org/pull/382

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/c3d153284840c85907b5485d3e4de9d7287d4de5
[bug979642_publishButton] - Moved inline script into separate file, deleted unused html file, changed include to linked script

https://github.com/mozilla/thimble.webmaker.org/commit/125a7c6926867b8e6fdd8a560f5bd5d14ed2499f
Merge pull request #382 from admix/bug979642_publishButton

[bug979642_publishButton] - Moved inline script into separate file, deleted unused html file, changed include to linked script