Closed
Bug 979681
Opened 10 years ago
Closed 10 years ago
Correctly handle SOURCES.flags for sources with relative paths in them
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I found out about this while porting the skia Makefile.in rules. We need to only deal with the file name here, not its relative path.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8385786 [details] [diff] [review] Correctly handle SOURCES.flags for sources with relative paths in them One liner, fast reviews much appreciated.
Attachment #8385786 -
Flags: review?(mshal)
Attachment #8385786 -
Flags: review?(mh+mozilla)
Attachment #8385786 -
Flags: review?(gps)
|
||
Updated•10 years ago
|
Attachment #8385786 -
Flags: review?(mshal)
Attachment #8385786 -
Flags: review?(mh+mozilla)
Attachment #8385786 -
Flags: review?(gps)
Attachment #8385786 -
Flags: review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Awesome, thanks for the fast review, glandium! https://hg.mozilla.org/integration/mozilla-inbound/rev/86674b21e4e2
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86674b21e4e2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•