979685 - Rewrite the qcms Makefile.in in moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[(no longer active)]

Attachment: Rewrite the qcms Makefile.in in moz.build

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8385790 [details] [diff] [review]
Rewrite the qcms Makefile.in in moz.build

>+        if CONFIG['OS_ARCH'] == 'WINNT' and '64' in CONFIG['OS_TEST']:

Since the Makefile has:

   ifneq ($(OS_ARCH)_$(OS_TEST),WINNT_x86_64)

I think this should be:

   if CONFIG['OS_ARCH'] != 'WINNT' or CONFIG['OS_TEST'] != 'x86_64':

>+elif CONFIG['CPU_ARCH'] == 'ppc':

Here the Makefile has:

   ifeq (ppc,$(findstring ppc,$(CPU_ARCH)))

which I think should be:

   elif 'ppc' in CONFIG['CPU_ARCH']:

The rest looks fine to me! Let me know if I misinterpreted these.

Comment 3

[(no longer active)]

Comment on attachment 8385790 [details] [diff] [review]
Rewrite the qcms Makefile.in in moz.build

You're right.

Comment 4

[(no longer active)]

Attachment: Rewrite the qcms Makefile.in in moz.build

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c05786691c47