979686 - sandbox unsupported on non x86/x86_64/arm platforms

Status: RESOLVED FIXED

(Toolkit Graveyard :: Security, defect)

Description

[Steve Singer (:stevensn)]

bug 970676
https://hg.mozilla.org/mozilla-central/rev/c1a0493fa09e 

turned MOZ_CONTENT_SANDBOX on for all Linux platforms. However linux_seccomp.h only has support for the tier 1 platforms.

Builds on powerpc give 
security/sandbox/linux/linux_seccomp.h:221:2: error: #error Unsupported target platform

I presume linux sparc or MIPS builds will give the same error.

Comment 1

[Steve Singer (:stevensn)]

Jeff, I don't have permissions to read or link to Bug 970676 so I am not sure the intent of the change is.

I can get things compiling again on ppc if I switch the #ifdef on 
 #include "mozilla/Sandbox.h
and in  RecvSetProcessPrivileges to be MOZ_CONTENT_SANDBOX instead of XP_LINUX but I'm not sure if that is correct?

Should we be setting MOZ_CONTENT_SANDBOX in configure.in for linux arm/x86/x86_64 ? Or do we need another flag that indicates if 
the platform is Sandbox capable?

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Yeah, that's broken.  I think I know what needs to be fixed here.

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug979686.diff

Try: https://tbpl.mozilla.org/?tree=Try&rev=2d24119670d4

Tested locally by adding an unconditional #error next to the one that was breaking and building x86_64 desktop.  Also tested that this doesn't regress on B2G/ARM.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Does attachment 8387029 [details] [diff] [review] fix the PPC desktop build for you?

Comment 5

[Steve Singer (:stevensn)]

ppc64 builds fine with this patch applied.
Thanks

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a83a9b580ab

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9a83a9b580ab