979771 - [DSDS] Data call icon on Utility Tray will not become blue even connection is established.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Enpei]

Attachment: 2014-03-05-15-52-41.png

Please refer to attached screenshot, the "E" is not in blue while 2G connection is established on SIM 2. 

I would like to nominate this since it's a basic UI inconsistency on DSDS project.  

* Build Number  
Fugu
Gaia      6781459a49642ca0eb7ec3e95667808d5d77b656
Gecko     d574219c44f75c9dfb007274e9de0479ef51020a
BuildID   20140305053055
Version   30.0a1

* Reproduce Steps
1. Set SIM 2 as primary outgoing data.
2. Enable SIM 2 data call. Drop down utility tray and check the data call icon

* Expected Result
Data call icon should be blue.

* Actual Result
Data call icon is still grey as data call is not enabled.

* Occurrence rate
100%

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8385982 [details] [review]
patch on master

Alive, the root cause of this bug is all about mozMobileConnection / mozMobileConnections. I also did some refactor and added unit tests for this. Please help me review this later ! Thanks !!

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8385982 [details] [review]
patch on master

r+ iff we can only enable data for one SIM card at one time.
If not, please use OR logic to display the data connection icon.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Alive Kuo [:alive][NEEDINFO!][:艾莉芙] from comment #3)
> Comment on attachment 8385982 [details] [review]
> patch on master
> 
> r+ iff we can only enable data for one SIM card at one time.
> If not, please use OR logic to display the data connection icon.

There is no this scenario like this for DSDA phones, so We don't have to worry about this at the moment !

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, merged on Gaia/master : d68074a17d9510623ae4dd3b9f50902af2b36dab

Comment 6

[Enpei]

Verified on Fugu.
Gaia      b5d0f9b0cd5dce38b79287a9363226b912929270
Gecko     7312341e00e2785419fc4746e291646299ba3018
BuildID   20140313120331
Version   30.0a1