979785 - [GAIA][BUILD SYSTEM] Overwrite common-setting.json by GAIA_DEVICE_TYPE in build/settings.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Difference devices may have different settings value, we need to create new method overwrite common-setting.json in build/settings.js

Comment 2

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/18974

Hi Yuren,
   Can you help to review this patch and give me some feedback?

   Thanks.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8417882 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/18974

we should use |GAIA_DEVICE_TYPE| to assemble the file path what you need in js, please see comment on github.

Comment 4

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8417882 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/18974

Hi Yuren,
   I've addressed your comment, please help to review this patch again.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8417882 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/18974

looks good, r=yurenju.

Comment 6

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

travis green:
https://travis-ci.org/mozilla-b2g/gaia/builds/24962717

land in master:
https://github.com/mpizza/gaia/commit/230ee3a4f57b875da803c68dbd0bca227b1d2f4f