97983 - ExtractUrlPart allows no access to the directory part of the url

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Andreas Otte]

ExtractUrlPart does not allow access to the directory part of an url. Also the
Start and Endpositions are sometimes calulated from the filebasename-string
although another part of the url is requested.

Comment 1

[Andreas Otte]

Fixing the calculation of start and endpositions from filebasename to the
correct string is an easy fix. 

On the other hand: do we really need these start and endpositions? It's easy to
find some examples where it will fail to calculate the right positions, as also
indicated by Doug's comment in the source.

The url_directory mask is missused to return the whole path. On the other hand
there is no way to access the directory component alone. This should be be fixed
with an additional mask url_Path. Before that can happen the url_-masks have to
be freed from their escape/unescape duties, dependency on bug 94796.

Comment 2

[Andreas Otte]

Attachment: patch to fix the position calculation problem and do some preparations for the sendond half

Comment 3

[Andreas Otte]

Attachment: complete patch

Comment 4

[Andreas Otte]

Now that 94796 is in the patch is complete. It introduces a new bitmask url_Path
which goes for the whole urlpath. The directory component can now be accessed by
it's normal bitmask. Also fixed start/endpositions as much as possible. 

Need r=/sr=

Comment 5

[Darin Fisher]

Comment on attachment 48692 [details] [diff] [review]
complete patch

glad to see this flag added :-)

and thanks for cleaning up some of this code.  sr=darin

Comment 6

[Andreas Otte]

fix checked in 

Comment 7

[(not reading, please use [e-mail] instead)]

I think this change broke something in mailnews.  see bug #99657

Comment 8

[Charles Manske]

this also busted my recent fix to Composer bug 72583!

Comment 9

[Andreas Otte]

Charlie, just replace all url_Directory masks with url_Path which is the correct
one if you want to get the whole path. 

Comment 10

[Charles Manske]

Yep! I figured that out, of course.