979833 - inconsistent presentation of message that number is not in FDN list.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[ayman maat :maat]

The dialogues for informing the user that FDN is active are very different both in information delivery, language and visual treatment between the Dialler app (refer to attachment ’01 Dialler’) and the Messages app (refer to ‘attachment 02 [details] [diff] [review] msg app 1 number’).  For consistency and continuity of UX across the platform we should ensure that the dialogue in the dialler app has the same visual treatment, language and information as that in the message app. 

Therefore the dialogue in the dialler app should read as follows:

      FDN Active
      FDN is activated and the following number is not in your FDN list:
      <phone number>

Comment 1

[ayman maat :maat]

Attachment: 01 Dialler.png

Comment 2

[ayman maat :maat]

Attachment: 02 msg app 1 number.png

Comment 3

[David Scravaglieri [:scravag]]

Blocking for string consistency, fix should be a more generic message like dependent bug 978130

Comment 4

[David Scravaglieri [:scravag]]

Anthony this is in your area ;)

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

set target milestone to 1.4 S4 for now

Comment 6

[Axel Hecht [:Pike]]

Given that we're way past strong string freeze, I'm moving this back into the triage bucket. This might have been a good idea a month ago, but do we really really need this now? David?

Comment 7

[Preeti Raghunath(:Preeti)]

Moving to backlog.

Comment 8

[Maria Angeles Oteo (:oteo)]

Bug 978130 - [FDN] Misleading message when trying to send an SMS in FDN mode, is 1.4+ and it's almost ready to land...so we should maintain the string consistency in both applications and fix this bug for 1.4 version.

Comment 9

[David Scravaglieri [:scravag]]

clear n?

Comment 10

[Noemí Freire (:noemi)]

Per comment 8 re-nominating this bug accordingly

Comment 11

[Axel Hecht [:Pike]]

I've moved bug 978130 into the triage queue, too. "close" isn't a good measure right now. What we need is "really really blocking"

Comment 12

[Anthony Ricaud (:rik)]

I'm working on this and I don't like the string used. Do we expect users to understand "FDN"? We use Fixed dialing numbers in settings.

Comment 13

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/18129

We might change the string message but that's not a blocker to review.

Comment 14

[Jason Smith [:jsmith]]

backlog since this breaks string freeze

Comment 15

[Carrie Wang [New account: [e-mail]]]

Agree with Anthony. Users won't get the meaning of "FDN".
My suggestion:

FDN Active
FDN (Fixed Dialing Numbers) is activated and the following number is not in your FDN list:
<phone number>

I've discussed with Omega and we suggest using this string in both Message and Dialer APP. Thanks!

Comment 16

[Etienne Segonzac (:etienne)]

Comment on attachment 8404037 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18129

all good!

Comment 17

[Anthony Ricaud (:rik)]

Committed with new message: https://github.com/mozilla-b2g/gaia/commit/2cee2e60b4b1659f6a7bfc8a8bcadcc2e6d37e23

Comment 18

[Anthony Ricaud (:rik)]

Of course I forgot to commit the message update…

So new commit: https://github.com/mozilla-b2g/gaia/commit/07b30ab53994a9da86d40eee5fb74154bf8c5c10