979840 - Use the gecko repository from the b2g performance data if present to link to the revision

Status: RESOLVED WONTFIX

(Datazilla Graveyard :: User interface, defect, P3)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

With bug 979829 we'll be submitting the gecko repository in addition to the changeset. We should use these together to construct the link in the b2g dashboard, and if the repository is not present then we should fall back to the current behavior of using the http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=<changeset> URL.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Byron: Is this something you might be able to help with? I took a look over the datazilla source, and wouldn't be too confident making this change without a local instance and some guidance - you most likely can take care of it much faster than me.

Comment 2

[Jonathan Griffin (:jgriffin)]

Dave, can you include an example of the new data format we plan on submitting to datazilla?

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Here's an example of what will be sent to datazilla:

{'test_machine': {'platform': 'Gonk', 'osversion': u'1.4.0.0-prerelease', 'os': 'Firefox OS', 'name': u'e4:2d:02:2b:44:63', 'type': 'hamachi'}, 'testrun': {'date': 1395165043, 'suite': 'phone'}, 'results': {'cold_load_time': [838]}, 'test_build': {'ro.build.date.utc': '1387787764', 'build_revision': u'59605a7c026ff06cc1613af3938579b1dddc6cfe', 'gaia_revision': 'a351fe62c11737c722ad33aaff438f6ccd00bd4a', 'id': u'20140310141048', 'restart': False, 'ro.build.version.incremental': 'eng.tclxa.20131223.163538', 'gecko_repository': 'https://hg.mozilla.org/mozilla-central', 'ro.build.version.release': '4.0.4', 'name': 'B2G', 'generated_by': 'b2gperf 0.19', 'delay': 1, 'version': 'prerelease', 'gecko_revision': '41d962d23e81', 'branch': 'test', 'settle_time': 0.0, 'revision': 'a351fe62c11737c722ad33aaff438f6ccd00bd4a'}}

Note:
'gecko_repository': 'https://hg.mozilla.org/mozilla-central'
'gecko_revision': '41d962d23e81'

Comment 4

[:glob ✱]

sorry, i've tried several times to make some time to look at this, but without success.
i do plan on doing this next time i have some non-bugzilla time available.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

should we link to hg.mozilla.org instead of git.mozilla.org?  If not, then we need a *translation* from the hg revision to the git revision.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Joel Maher (:jmaher) from comment #6)
> should we link to hg.mozilla.org instead of git.mozilla.org?  If not, then
> we need a *translation* from the hg revision to the git revision.

Yes, that's what this bug is for. We now send the gecko repository in addition to the changeset. We just need to concatenate them. For older data we should use the git repository with the changeset.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

So we would use:
'gecko_repository': 'https://hg.mozilla.org/mozilla-central'
'gecko_revision': '41d962d23e81'

To create a link to 'http://hg.mozilla.org/mozilla-central/rev/41d962d23e81'. I suppose that's not just concatenation as we have the '/rev/' in there too, so we perhaps need to inspect the repository URL to see if it's hg. Alternatively, as this has been like this for a while now, we could just support the hg.m.o URLs and drop support for the old data. Not ideal though.

Comment 9

[Hubert Figuiere [:hub]]

We can map hg to git. There is a mapfile available. Ask :huseby

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Hubert Figuiere [:hub] from comment #9)
> We can map hg to git. There is a mapfile available. Ask :huseby

But we don't want to here. We used to have the git revision, and now we have the hg one. This was an enhancement so we don't want to just translate it back to git. If we wanted that we'd have just kept the git revision. :) Unless I'm misunderstanding something and that the git revision is actually preferred?

The reason it was git initially is because that's all we could reasonably extract from sources.xml but with mozversion we now get the hg revision from App.ini.

Comment 11

[Hubert Figuiere [:hub]]

I don't know what the rationale was but since it is b2g we build. we build it from git. So having the git sha1 is easier. Now maybe there is a different reason, and it doesn't matter, as long as the link is correct.

Comment 12

[Jonathan Griffin (:jgriffin)]

We use tinderbox builds for testing, and tinderbox builds are made using hg gecko repos (e.g., mozilla-central) and not their git.mozilla.org mirrors.

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This is still broken. To be honest the results containing git revisions are so dated now it's probably safe to just switch to the mercurial revision and not worry about the old links. Jeads: Do you think this would be a good mentored bug?

Comment 15

[Jonathan Griffin (:jgriffin)]

Clearing the needinfo.  We're shifting our resources to getting perf data in Treeherder.  If this seems like a priority, please needinfo me.