Closed Bug 979887 Opened 10 years ago Closed 10 years ago

Build warnings in memory/

Categories

(Core :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Details

Attachments

(2 files, 1 obsolete file)

... should be cleaned up.
Comment on attachment 8386114 [details] [diff] [review]
[01] Bug 979887: Fix GCC warnings about inline variable declarations

Review of attachment 8386114 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/build/mozmemory_wrap.c
@@ +95,5 @@
>  vasprintf_impl(char **str, const char *fmt, va_list ap)
>  {
> +  char* ptr;
> +  int ret;
> +  char* _ptr;

might as well put on the same line as ptr.
Attachment #8386114 - Flags: review?(mh+mozilla) → review+
Attachment #8386117 - Flags: review?(mh+mozilla) → review+
Changes to v1:

  - declare ptr and _ptr on the same line
Attachment #8386114 - Attachment is obsolete: true
Attachment #8386662 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f7774b42f02e
https://hg.mozilla.org/mozilla-central/rev/55068d2ff9e7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: