Closed
Bug 979887
Opened 10 years ago
Closed 10 years ago
Build warnings in memory/
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: tzimmermann, Assigned: tzimmermann)
Details
Attachments
(2 files, 1 obsolete file)
664 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
2.38 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
... should be cleaned up.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8386114 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8386117 -
Flags: review?(mh+mozilla)
Comment 3•10 years ago
|
||
Comment on attachment 8386114 [details] [diff] [review] [01] Bug 979887: Fix GCC warnings about inline variable declarations Review of attachment 8386114 [details] [diff] [review]: ----------------------------------------------------------------- ::: memory/build/mozmemory_wrap.c @@ +95,5 @@ > vasprintf_impl(char **str, const char *fmt, va_list ap) > { > + char* ptr; > + int ret; > + char* _ptr; might as well put on the same line as ptr.
Attachment #8386114 -
Flags: review?(mh+mozilla) → review+
Updated•10 years ago
|
Attachment #8386117 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Changes to v1: - declare ptr and _ptr on the same line
Attachment #8386114 -
Attachment is obsolete: true
Attachment #8386662 -
Flags: review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks, Mike. https://hg.mozilla.org/integration/b2g-inbound/rev/f7774b42f02e https://hg.mozilla.org/integration/b2g-inbound/rev/55068d2ff9e7 https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=55068d2ff9e7
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f7774b42f02e https://hg.mozilla.org/mozilla-central/rev/55068d2ff9e7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•