979936 - delete unused `quiet' param-handling code in setup.js

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: delete unused `quiet' param-handling code in setup.js

AFAICS from mochitest_options.py or runtests.py's buildURLOptions:

http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#291

there's no `quiet' param that can be provided as a URL parameter.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8386208 [details] [diff] [review]
delete unused `quiet' param-handling code in setup.js

Review of attachment 8386208 [details] [diff] [review]:
-----------------------------------------------------------------

good find.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: delete unused `quiet' param-handling code in setup.js

So, thinking about this and testing this shows the previous patch to be
spectacularly wrong, since if |params.quiet| does not exist, then
|!params.quiet| is always true.  Hence, the logging listener was always added.
Deleting the logging listener, therefore, causes lots of things to go wrong,
such as TEST_{START,END,etc.} messages not being printed...

I've corrected that mistake in the attached patch, moving the addListener()
call down close to initialization code, rather than in the middle of checking
params for various values.  I don't see anything wrong with carrying over r+ on
this, though I am going to sanity-check this with Try, just to make sure.

Comment 4

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/334db4ff0617

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/334db4ff0617