979969 - [Calendar] calendar.isViewActive should check if element is really "active" on the marionette tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Miller Medeiros [:millermedeiros]]

I'm almost sure we are having some race condition problems related to the way all the "waitForView" methods are implemented in the calendar app.

We are currently only checking if the `body[data-path]` matches the expected value, but in some cases I think Travis delays the JS execution and the class ".active" is not added to the element until the "next tick". - most elements toggle display and z-index based on the class ".active"

I was also having some trouble with marionette `element.displayed()`, and I was not able to identify the root cause, so I think we should avoid using it. Checking for the `.active` class should be enough.

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16912

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Oops sorry!

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8386231 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16912

Thanks for this millermedeiros!

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/8a34caf66e8d0358b6ba819e81382e285d8ebec4