979992 - [Gaia][System][Window Manager] Status bar is missing during attention screen showing in fullscreen app.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Tony Nguyen]

Attachment: screenshot

Description:
When trying to pair with another device from Gallery or Video App, the user will notice that the status bar is missing. 

Repro Steps:
1) Updated Buri to BuildID: 20140305040204
2) Navigate to Gallery App
3) Tap on any image to view it fullscreen
4) Tap on share icon then -> "Bluetooth Transfer"
5) Tap on any bluetooth device

Actual Result:
Status bar is missing during Bluetooth Request Form

Expected Result:
Status bar is present during Bluetooth Request Form

Environmental Variables:
Device: Buri Master M-C mozRIL
BuildID: 20140305040204
Gaia: 6781459a49642ca0eb7ec3e95667808d5d77b656
Gecko: e5b09585215f
Version: 30.0a1
v1.2-device.cfg

Attached: screenshot, YouTube link

Note: This issue only happens when the user tries to pair from Gallery and Video App. It works correctly through the Music and Settings App.

Comment 1

[Jason Smith [:jsmith]]

Fullscreen apps don't show the status bar, so this is invalid.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #1)
> Fullscreen apps don't show the status bar, so this is invalid.

Looking at this more - the screenshot is coming from the Bluetooth app, not the gallery app. In that case, a status bar should be present.

Comment 3

[Jason Smith [:jsmith]]

Sounds like this is an activity management regression from moving from a fullscreen app to a non-fullscreen app.

Can we confirm this doesn't reproduce on 1.3?

Comment 4

[Tony Nguyen]

This issue doesn't reproduce on Buri v1.3. The status bar is always present while the Bluetooth Request Form is being displayed.

Environmental Variables:
Device: Buri v1.3 mozRIL
BuildID: 20140305004003
Gaia: 9b29f80309212bd80fbdcf2882458b1ae8b30093
Gecko: b3478af0151e
Version: 28.0
v1.2-device.cfg

Comment 5

[Preeti Raghunath(:Preeti)]

Alive

Please help with backout of regressing patch.

Comment 6

[Peter Bylenga [:PBylenga]]

The issue reproduces on the earliest inbound build that we have available at the moment, also the gecko/gaia swap test was inconclusive (both failed) providing both Gaia and Gecko pushlogs although the Gecko pushlog is empty.

The Regression window is as follows:
Last working Tinderbox Build

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ
BuildID: 20140204113223
Gaia: 75e9691f02b9d18585c18a5434beeff39ee7ea20
Gecko: 55614a949bde
Version: 30.0a1
Firmware Version: v1.2-device.cfg

First broken Tinderbox Build

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ
BuildID: 20140204114427
Gaia: ac94739a01d64e86890f54f1795ff8e82b8e7939
Gecko: 2c366892729d
Version: 30.0a1
Firmware Version: v1.2-device.cfg


Last Working Gaia/First Broken Gecko: Issue DOES Reproduce
 Gaia: 75e9691f02b9d18585c18a5434beeff39ee7ea20
 Gecko: 2c366892729d
 
First Broken Gaia/Last Working Gecko: Issue DOES Reproduce
 Gaia: ac94739a01d64e86890f54f1795ff8e82b8e7939
 Gecko: 55614a949bde

https://github.com/mozilla-b2g/gaia/compare/75e9691f02b9d18585c18a5434beeff39ee7ea20...ac94739a01d64e86890f54f1795ff8e82b8e7939

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2c366892729d&tochange=55614a949bde

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Ian please help to check.

Comment 8

[Jason Smith [:jsmith]]

The regression window here isn't right. You need to bisect using m-c builds if there are no inbound builds available.

Comment 9

[Peter Bylenga [:PBylenga]]

From m-c

Last Working build:

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ
BuildID: 20140203040201
Gaia: 3b2fe2f86164f95db699b6ea2661925b21ecb994
Gecko: 44ba69cacd7e
Version: 29.0a1
Firmware Version: v1.2-device.cfg


First Broken build:

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ
BuildID: 20140204040201
Gaia: 75e9691f02b9d18585c18a5434beeff39ee7ea20
Gecko: c150845d077d
Version: 30.0a1
Firmware Version: v1.2-device.cfg


Last Working Gaia/First Broken Gecko: Issue Does NOT Reproduce
 Gaia: 3b2fe2f86164f95db699b6ea2661925b21ecb994
 Gecko: c150845d077d
 
First Broken Gaia/Last Working Gecko: Issue DOES Reproduce
 Gaia: 75e9691f02b9d18585c18a5434beeff39ee7ea20
 Gecko: 44ba69cacd7e

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/3b2fe2f86164f95db699b6ea2661925b21ecb994...75e9691f02b9d18585c18a5434beeff39ee7ea20

Comment 10

[[e-mail], [e-mail]]

Attachment: 2014-03-09-21-23-31.png

Looks like the status bar is block in Gallery app sharing via bluetooth. Gallery app is a fullscreen mode app. I also try Music app(not fullscreen) to share via bluetooth. The status bar is working fine to display.

=========== build version ===========
Gaia      98cf46d6623b164845fe1fdc99a2a7bf64aa667d
Gecko     https://hg.mozilla.org/mozilla-central/rev/8095b7dd8f58
BuildID   20140306160203
Version   30.0a1
ro.build.version.incremental=eng.cltbld.20140105.073001
ro.build.date=Sun Jan  5 07:53:36 EST 2014

Comment 11

[[e-mail], [e-mail]]

Since "Bug 958584 - Swiping from the top to make the status bar appear in fullscreen" is landed, we use transition to control status bar show/hide. Each time, app is opened, utility tray hide, rocket bar hidden, we will check the app is fullscreen or not. If it's a fullscreen app, we will hide status bar(applied the transition). But we don't remove the "invisible" property while the attention screen is showing in fullscreen app. So the issue is influenced Dialler, Clock, Bluetooth pairing who used attention screen in fullscreen app. 

Alive, Etienne,

Shall we fix it or revert the patch since rocket bar is reverted now?

Comment 12

[Etienne Segonzac (:etienne)]

Thanks for figuring this one out Ian!
Since the status bar patch is not directly tied to the rocket bar, I think we should fix the issue.

Happy to steal it from you if you want :)

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Clear.

Comment 14

[[e-mail], [e-mail]]

Attachment: pull request 17060

Comment 15

[[e-mail], [e-mail]]

(In reply to Ian Liu [:ianliu] from comment #14)
> Created attachment 8389040 [details] [review]
> pull request 17060

Etienne, could you please help to review the pr? Thanks.

Comment 16

[Etienne Segonzac (:etienne)]

Comment on attachment 8389040 [details] [review]
pull request 17060

Thanks for the fix Ian, it works perfectly :)

I have a few comments/questions about the test on github, so I'd like to have another quick look at the patch once we firgure those out.

Comment 17

[[e-mail], [e-mail]]

Comment on attachment 8389040 [details] [review]
pull request 17060

Etienne, thanks for your reviewing effort. I have revised it with those suggestion on GitHub. Will need your look again.

Comment 18

[Etienne Segonzac (:etienne)]

Comment on attachment 8389040 [details] [review]
pull request 17060

r=me with nits on the tests names.

Thanks!

Comment 19

[[e-mail], [e-mail]]

Thanks for Etieenne's reviewing effort. And the patch is revised without redundant test name. Since the pr is merged, we can close the issue now.

Gaia/master: 7ce7e5440e3f8ad55337f77b7047ebd2b37ccce8