980052 - Crash in mozilla::MediaStreamGraphImpl::RunThread() while receiving calls and sms

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Greg Grisco]

Attachment: decoded minidump of crash

Similar stack trace to bug 947431:

Test steps:
1. Run a script with Call, SMS, camcorder, Music , Video and camera test cases.
2. After Day and night run, mini dumps are generated in the phone.

Comment 1

[Greg Grisco]

Attachment: EXTRA file attachment

Comment 2

[Greg Grisco]

This happened once so far on a 1.3 build that was made on 2/26/2014.

Comment 3

[Sandip Kamat]

PM Triage: 1.3 stability needs to reach target MTBFs. Stays 1.3+

Comment 4

[Gregor Wagner [:gwagner]]

Hema, is this your team or media recording?

Comment 5

[Hema Koka [:hema]]

Don't have experts in media apps team; Media recording guys are probably the best to take a look at this 

thanks
hema

Comment 6

[Paul Adenot (:padenot)]

Attachment: Compare the value and not the pointer when checking validity of the preferred sample rate in the OpenSL cubeb backend.

Hrm, sorry about that :-/.

Comment 7

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/61a399044b5a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/61a399044b5a

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for approval-mozilla-b2g28 when you get a chance. Also, is this something !B2G would benefit from on Aurora29?

Comment 10

[Preeti Raghunath(:Preeti)]

Please request approval per form

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 11

[Paul Adenot (:padenot)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9)
> Please nominate this for approval-mozilla-b2g28 when you get a chance. Also,
> is this something !B2G would benefit from on Aurora29?

Will do. This code is also used on Android > 2.3, although triggering the bug would be extremely difficult. Since this patch is trivial, I'll nominate it as well.

Comment 12

[Paul Adenot (:padenot)]

Comment on attachment 8388922 [details] [diff] [review]
Compare the value and not the pointer when checking validity of the preferred sample rate in the OpenSL cubeb backend.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 947431
User impact if declined: crash because of division by zero exception
Testing completed: this is a very obvious programming error
Risk to taking this patch (and alternatives if risky): little risk, this is very obvious. Alternative is having a crash.
String or UUID changes made by this patch: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/267fa4461c3a
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/1f3bb1cedb16

Comment 14

[cafbot (PoC: ggrisco)]

Observed on: 

Device: 
Gonk Version: AU_LINUX_GECKO_B2G_JB_3.2.01.03.00.112.255
Moz BuildID: 20140226004002
B2G Version: 1.3
Gecko Version: 28.0
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=8039a5cb7519adfa81677df577f494c6a4de6140
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=7599b5ccc906f556076798fc062a9e51e2c0eece

Comment 15

[cafbot (PoC: ggrisco)]

Observed on: 

Device: msm8226
Gonk Version: AU_LINUX_GECKO_B2G_KK_3.6.01.04.00.000.043
Moz BuildID: 20140721000201
B2G Version: 1.3
Gecko Version: 32.0a2
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=5f27d3ee3ccf01ac91a3efacb5e3e22ea62fd73c