Closed Bug 980058 Opened 9 years ago Closed 9 years ago

[IARC] USK display issues (translations, incorrect link)

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2014-03-11

People

(Reporter: kngo, Assigned: kngo)

References

Details

(Whiteboard: [cosmetic])

Attachments

(1 file, 3 obsolete files)

New diff
3.10 KB, patch
Details | Diff | Splinter Review 
*FROM EMAIL*

"Below you will find a detailed list from USK of several display issues they have found on German version of the Firefox Marketplace."
 
Just as discussed yesterday, attached are some screenshots with the current display of Age Ratings, Content Descriptors and Interactive Elements in the Mozilla Firefox Marketplace which are, unfortunately, still all mixed up and wrong for the most part. They seem to have been translated by Mozilla themselves but we really need them to display it exactly as follows:
 
 
Ratings:
 
USK ab 0 Jahren
USK ab 6 Jahren
USK ab 12 Jahren
USK ab 16 Jahren
USK ab 18 Jahren
 
And in case those are needed as well:
 
Kein Kennzeichen (Refused Classification)
Einstufung ausstehend (Rating Pending)
Ungeprüft (Unrated)
 
 
Content Descriptors:
 
Gewalt (Violence)
Erotik/ sexuelle Inhalte (Sexual Content)
Explizite Sprache (Explicit Language)
Ängstigende Inhalte (Fear)
 
 
Interactive Elements:
 
Interaktion zwischen Nutzern (Users Interact)
Weitergabe von Daten (Shares Info)
Weitergabe des Standortes (Shares Location)
Onlinekäufe (Digital Purchases)
 
 
Also, another very important detail is the link behind
“Details zur Altersbewertung” (age rating details)
on the apps’ info page. It still leads to the official (governmental) rating info on http://www.usk.de/pruefverfahren/alterskennzeichen/. This can lead to serious issues for us and the IARC system acceptance, so the correct link must be
 
www.usk.de/iarc0
 
But there’s even more: for many games, the details page is sometimes missing the content descriptors altogether. I took a screenshot from “Cage Fighter” which received a 12+ for violence, see attached. My guess is that it might “just” be a technical issue on Mozilla’s side.
 
That’s quite a list- thanks for taking care of this!
Assignee: nobody → kngo
Blocks: 929812
Priority: -- → P2
Summary: [iarc] USK display issues (translations, incorrect link, missing descriptors) → [IARC] USK display issues (translations, incorrect link, missing descriptors)
Target Milestone: --- → 2014-03-11
CCing Michael, the localizer, for courtesy.  Michael - the IARC has some specific wording they'd like for their interactive elements.  Kevin has made a pull request at https://github.com/mozilla/zamboni/pull/1839/files which I'm going to accept.  Let us know if you have any concerns.  Cheers.
Everything fixed except the missing content descriptors which is being investigated.

STR:

1. Go to detail page of app with content ratings in Germany region.

Expected:

The IARC-related German strings match the ones above.

Content descriptors are not missing.

Actual:

Wording is different.

Descriptors may be missing
Attached patch Diff of updated po file (obsolete) — — Splinter Review 
Hi, feel free to make any necessary changes to meet the requirements. If there’s any action required from me, please let me know.

Not sure if that’s of any help but anyway, the last update apparently modified the charset from UTF-8 to Windows-1252. I’m attaching a diff of my last checkin from Verbatim to an updated file, which I hope contains all the necessary updates.


A word about the link for „age rating details“: I couldn’t find this in any of the files. Fireplace has a string „Content rating details“ which is used on an app’s info page, but there’s no link that I could modify.
Comment on attachment 8386658 [details] [diff] [review]
Diff of updated po file

Sorry, there was something wrong with the upload.
Attachment #8386658 - Attachment is obsolete: true
This one should work.
Michael, here are some more updates. Could you submit a pull request to make sure I don't mess up the charset?

"After receiving the Firefox OS phone available in Germany today it seems like the “Interactive Elements” could be too long in its wordings for a decent display in the app’s details. Therefore, here is a shortened, preferred version which you can use:
 
Interactive Elements:
 
Nutzerinteraktion (Users Interact)
Datenweitergabe (Shares Info)
Standortweitergabe (Shares Location)
Onlinekäufe (Digital Purchases)"
Flags: needinfo?(coce)
Michael: let me know if you're unsure about the pull request, I can do it pretty quickly
Attached patch Diff with shorter strings (obsolete) — — Splinter Review 
Hi Kevin, could you please take a look at this diff? I hope it contains all the required updates, including the shortened versions.

When I get your r+, I’ll check in the file and make a pull request.

Wil, if you’re faster than me (it’s late in the evening here), feel free to do it yourself. The diff compares my updates to my last update via Verbatim, <https://github.com/mozilla/zamboni/commit/1b91fbbe76ecfa330397c5adbcf6a6a1c5a4ec95>.
Attachment #8386665 - Attachment is obsolete: true
Attachment #8387077 - Flags: review?(kngo)
Flags: needinfo?(coce)
I added it here, Michael. Let me know if anything is wrong: https://github.com/mozilla/zamboni/commit/de32793a857ef12b99948376470ea773438b106f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8387077 [details] [diff] [review]
Diff with shorter strings

Thanks. Though the diff appears to be a little shorter than what I just uploaded to this bug, it seems that all the necessary changes are there.

Two issues:

1) I think there is an „e“ missing on
msgid "Digital Purchases"
msgstr "Onlinekäuf"

2) The charset again is Windows-1252, which seems to mess up certain characters, and will likely make the file unusable for Verbatim.
Attachment #8387077 - Flags: review?(kngo)
Also David, from the email, it said "Cage Fighter" received a 12+ for Violence. On our side, that app no longer holds the USK Violence descriptor. Can you check the certificate 1575 and see if it is supposed to?
Michael, could you help me fix the file whenever you're available? The file is currently on Zamboni master.
Attached patch New diff — — Splinter Review 
Kevin, please take a look at the diff in this comment. It contains all the changes I’m about to make, and I hope these are all that are required. Please review it, and let me know if it’s ok. If it is, I will check it in and create a pull request. If there’s something wrong or missing, please let me know and I will make the changes. That way, we should be able to keep UTF-8.
Attachment #8387077 - Attachment is obsolete: true
Attachment #8387170 - Flags: review?(kngo)
Michael: r+
Comment on attachment 8387170 [details] [diff] [review]
New diff

Thanks. I created a pull request: <https://github.com/mozilla/zamboni/pull/1846>.
Attachment #8387170 - Flags: review?(kngo)
Thanks, Michael!
Glad to be of service!
Huh. Even though the file totally looks like UTF-8, Verbatim refuses to update, citing problems with character encoding. The error message is

Server Error

An error has occurred. Thank you for your patience.
('utf8', '"\xc4ngstigende Inhalte"', 1, 3, 'invalid data')
If you need assistance, you may refer to this error as f40645ec202c48cb81282e8126c35603$1dd5914fbcbccfc3bae3cf6e2835c69c.


Wil, could you please look into that?
Flags: needinfo?(clouserw)
I don't know Verbatim, but I did manually update the .po files. Not sure if Verbatim breaks if I do that.
I'm looking at HEAD and it looks fine.  The message string is correct and the file is "UTF-8 Unicode PO" which is what we want.  I'll CC :mathjazz who can check if verbatim is stuck on an older version.
Flags: needinfo?(clouserw)
(In reply to Kevin Ngo [:ngoke] from comment #11)
> Also David, from the email, it said "Cage Fighter" received a 12+ for
> Violence. On our side, that app no longer holds the USK Violence descriptor.
> Can you check the certificate 1575 and see if it is supposed to?

This still has a violence descriptor in our system.

"Gewalt"

Please let me know when these fixes are pushed live so that I can have USK review them.  Thanks again.
Summary: [IARC] USK display issues (translations, incorrect link, missing descriptors) → [IARC] USK display issues (translations, incorrect link)
Moved missing descriptors bug to https://bugzilla.mozilla.org/show_bug.cgi?id=981100
The diff looks strange, but that might be GitHub issue:
https://github.com/mozilla/zamboni/pull/1846/files

The file looks OK and Verbatim looks updated.

Not sure why the server error occures on update. Adding Dwayne.
"Refused Classification" image is not translated. Is this expected or this should also be translated?
Please see screencast http://screencast.com/t/eloAU42Y
Flags: needinfo?(kngo)
(In reply to Iulian Timis from comment #24)
> "Refused Classification" image is not translated. Is this expected or this
> should also be translated?
> Please see screencast http://screencast.com/t/eloAU
(In reply to Iulian Timis from comment #24)
> "Refused Classification" image is not translated. Is this expected or this
> should also be translated?
> Please see screencast http://screencast.com/t/eloAU42Y

If it is "Refused Classification", it shouldn't be released...so technically it doesn't need to be translated.  I'm not sure why that app is on the storefront.
(In reply to David Kassack from comment #26)
> (In reply to Iulian Timis from comment #24)
> > "Refused Classification" image is not translated. Is this expected or this
> > should also be translated?
> > Please see screencast http://screencast.com/t/eloAU42Y
> 
> If it is "Refused Classification", it shouldn't be released...so technically
> it doesn't need to be translated.  I'm not sure why that app is on the
> storefront.

So, just to be clear for me on how to verify this bug, the text from Content Descriptors and Interactive Elements should be correctly translated to DE in App details page (Consumer pages)?
Thank you.
Yes it should for the German storefront.  However, the "Refused Classification" icon should never be displayed in any language.  If the app is refused classification by USK (Germany), it shouldn't be available on the German storefront.

I hope that helps.
(In reply to Michael 'Coce' Köhler from comment #18)
> Huh. Even though the file totally looks like UTF-8, Verbatim refuses to
> update, citing problems with character encoding. The error message is
> 
> Server Error
> 
> An error has occurred. Thank you for your patience.
> ('utf8', '"\xc4ngstigende Inhalte"', 1, 3, 'invalid data')
> If you need assistance, you may refer to this error as
> f40645ec202c48cb81282e8126c35603$1dd5914fbcbccfc3bae3cf6e2835c69c.
> 
> 
> Wil, could you please look into that?

Do you have the actual file so that I can have a look.

It is possible to put e.g. iso-8859-1 encoded data into a file in the text editor, depends on the editor.

Pootle will use the PO header which specifies the PO file encoding, so my guess is that it is failing because the two don't match.  Not a very elegant failure though.


(In reply to Matjaz Horvat [:mathjazz] from comment #23)
> The diff looks strange, but that might be GitHub issue:
> https://github.com/mozilla/zamboni/pull/1846/files
> 
> The file looks OK and Verbatim looks updated.
> 
> Not sure why the server error occures on update. Adding Dwayne.

That looks like what happens when encodings are mixed. You're seeing the ASCII rendering of code points that would be used for the UTF-8 character.

So look almost certain to be a badly encoded PO file.
(In reply to David Kassack from comment #28)
> Yes it should for the German storefront.  However, the "Refused
> Classification" icon should never be displayed in any language.  If the app
> is refused classification by USK (Germany), it shouldn't be available on the
> German storefront.
> 
> I hope that helps.

I think that the app is in storefront because the user used for login is the developer of the app or it is an user with special permissions. If you will try the same link, with another user without any permissions , you should receive an error.
(In reply to Dwayne Bailey from comment #29)
> Do you have the actual file so that I can have a look.


I would assume that Verbatim currently tries to use this file: <https://github.com/mozilla/zamboni/blob/6bdbe2ba7a14176dd7dc4191515ebda81ba36aa3/locale/de/LC_MESSAGES/messages.po>.

About the charset, I’m somewhat confused, because I edited the file based on my latest commit from Verbatim, and I therefore assumed that any errors in the charset should be fixed. Thanks for looking into that.
I just want to confirm.  So far everything on this  bug has been cleared up except the missing content descriptors...correct?
Yes it should be. The descriptors issue will be addressed soon: https://bugzilla.mozilla.org/show_bug.cgi?id=981100
Flags: needinfo?(kngo)
Any news on the Verbatim issue? I tried to download the file and upload it to Verbatim but when I then try to check in, the same error occurs. So it indeed seems to be a badly encoded file. Any ideas?
Let's try checking out the last clean file, and re-do the recent IARC translations: https://raw.github.com/mozilla/zamboni/941eba3f02f8dfb2d9957364768aab07acbee83b/locale/de/LC_MESSAGES/messages.po

Sorry, this was my bad for doing it outside of Verbatim.
I created a new pull request: <https://github.com/mozilla/zamboni/pull/1868>. It should contain all the changes we made before, but the file was saved with Poedit, which is why the diff is so long. Let’s hope it works.
Pull request closed, but I'm still getting the same error in Verbatim.

Investigating further.
I replaced Ä with A in the problematic string on the verbatim box and after that I was able to commit.

I replaced A with Ä again and commited again.

I had some problems during the process (e.g. suddenly all translations in messages.po disappeared), but eventually things seem to be working now.
Excellent job, everything seems to be working now. Thanks!
Could we add the new German strings to Fireplace too?

https://github.com/mozilla/fireplace/blob/master/locale/de/LC_MESSAGES/messages.po
Whiteboard: [cosmetic]
Michael, could you also change "For All Ages" to read "ab 0 Jahren" as requested by IARC/USK? I left an L10n note. Thanks!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
On Fireplace**
I hope it’s correct now.
Another small thing, could you change it to start lowercased?

"ab {0} Jahren" instead of "Ab {0} Jahren"
Like this?
Perfect, thanks Michael!
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.