980130 - Bookmarks menu button breaks after reset if it used to be in the panel

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

It should listen for onWidgetReset as well.

Comment 1

[:Gijs (he/him)]

Attachment: bookmarks button breaks after reset in Australis customize mode,

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8386787 [details] [diff] [review]
bookmarks button breaks after reset in Australis customize mode,

Review of attachment 8386787 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-places.js
@@ +1178,3 @@
>  
> +  onWidgetRemoved: function BUI_widgetRemoved(aWidgetId) {
> +    if (aWidgetId == "bookmarks-menu-button") {

it would be swell if this ID was a defined as a constant somewhere.

::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +2470,5 @@
>     *     Fired after a reset to default placements moves a widget's node to a
>     *     different location. aNode is the widget's node, aContainer is the
>     *     area it was moved into (NB: it might already have been there and been
>     *     moved to a different position!)
> +   *   - onWidgetUndoReset(aNode, aContainer)

Can we rename this to onWidgetUndoMove so that it will be future compatible with when we allow undo's of single item moves?

Comment 3

[:Gijs (he/him)]

https://hg.mozilla.org/integration/fx-team/rev/f16cb820431b

Comment 4

[:Gijs (he/him)]

Updated CUI docs on MDN.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f16cb820431b

Comment 6

[:Gijs (he/him)]

Comment on attachment 8386787 [details] [diff] [review]
bookmarks button breaks after reset in Australis customize mode,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: bookmarks menu doesn't behave correctly under certain circumstances
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low - we would have noticed significant issues by now.
String or IDL/UUID changes made by this patch: none

Comment 7

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7040d27132bc