Closed Bug 980136 Opened 6 years ago Closed 6 years ago

Intermittent devicestorage/test/test_fs_get.html | Failed to created test files.

Categories

(Core :: DOM: Device Interfaces, defect)

29 Branch
All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30
Tracking Status
firefox28 --- unaffected
firefox29 --- unaffected
firefox30 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: xyuan)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=35690871&tree=B2g-Inbound
slave: tst-linux32-spot-372



16:51:03     INFO -  4913 INFO TEST-END | /tests/dom/devicestorage/test/test_fs_createDirectory.html | finished in 139ms
16:51:03     INFO -  4914 INFO TEST-START | /tests/dom/devicestorage/test/test_fs_get.html
16:51:04     INFO -  4915 INFO TEST-INFO | dumping last 2 message(s)
16:51:04     INFO -  4916 INFO TEST-INFO | if you need more context, please use SimpleTest.requestCompleteLog() in your test
16:51:04     INFO -  4917 INFO TEST-PASS | /tests/dom/devicestorage/test/test_fs_get.html | Should have getDeviceStorage.
16:51:04     INFO -  4918 INFO TEST-PASS | /tests/dom/devicestorage/test/test_fs_get.html | Should have gotten a storage.
16:51:04     INFO -  4919 INFO TEST-UNEXPECTED-FAIL | /tests/dom/devicestorage/test/test_fs_get.html | Failed to created test files.
16:51:04     INFO -  4920 INFO TEST-INFO | MEMORY STAT vsize after test: 602173440
16:51:04     INFO -  4921 INFO TEST-INFO | MEMORY STAT residentFast after test: 130584576
16:51:04     INFO -  4922 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 46872764
16:51:04     INFO -  4923 INFO TEST-END | /tests/dom/devicestorage/test/test_fs_get.html | finished in 130ms
16:51:04     INFO -  4924 INFO TEST-START | /tests/dom/devicestorage/test/test_lastModificationFilter.html
16:51:05     INFO -  We still have length = 0
Yuan - could you take a look at this?
Flags: needinfo?(xyuan)
Yes. The test failed to create a new file "sub1/sub2/test.png" with DeviceStorage#addNamed. It is likely the test tries to create an existing file.
Assignee: nobody → xyuan
Flags: needinfo?(xyuan)
Comment on attachment 8386537 [details] [diff] [review]
Fix creating test file failure.

Review of attachment 8386537 [details] [diff] [review]:
-----------------------------------------------------------------

Shouldn't every success/failure path call devicestorage_cleanup() ?
No.

When creating a test file, we first try to get it in case it already exists.
If it does not exists, onerror was called, we need to create the file, but 
that doesn't mean the test fails.
Status: NEW → ASSIGNED
Comment on attachment 8386537 [details] [diff] [review]
Fix creating test file failure.

Review of attachment 8386537 [details] [diff] [review]:
-----------------------------------------------------------------

ok - I wasn't looking at the whole file.
Attachment #8386537 - Flags: review?(dhylands) → review+
Thanks :)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Backed out along with bug 910412 and other dependencies for ongoing crashes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce7915f22b2d
You need to log in before you can comment on or make changes to this bug.