980138 - Display total number of results found for a search

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Potts [:justinpotts]]

This feature would display the total number of results for the entire search, including every user on each page, much like Google's where it says, "123456 results found..." This count would be for just users and would not apply to groups.

Comment 1

[Matjaz Verbole]

Is this bug relevant to go to develop?
If it is and nobody is working on it, I can take it.

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

Matjaz, I think we just need a quick mockup of where the number would go and how it would look. If you're up for it, you could put together a mockup (using a screenshot and an image editor, or even just using Firefox Dev Tools!) and upload it here for review. Let us know if you want to do that.

Comment 3

[Matjaz Verbole]

Yes, I may do this. I'll use Firebug and paste screenshot here.

Comment 4

[Matjaz Verbole]

Attachment: mozillians_search_results.png

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

Thanks Matjaz!

I like the style and placement -- perfect! 

I suggest we make the message include the search term: 1 group matching "sil"

:williamr, what do you think about this mockup -- can Matjaz proceed, or do you have any other feedback?

I'm adding :giorgos as a mentor for this.

Comment 6

[William Reynolds [:williamr]]

Matjaz, this looks great! Thanks for the mockup.

I like that you included pluralization in the mockup (group/groups).

(In reply to Justin Crawford [:hoosteeno] from comment #5)
> I suggest we make the message include the search term: 1 group matching "sil"

I like this idea. So there will be two strings, one for each section:
1 group matching "sil"
2 Mozillians matching "sil"

> :williamr, what do you think about this mockup -- can Matjaz proceed, or do
> you have any other feedback?

Matjaz, go ahead and proceed!

Comment 7

[Matjaz Verbole]

Thank you Justin and William for great advices.
I did it like you suggested.

Comment 8

[William Reynolds [:williamr]]

https://github.com/mozilla/mozillians/pull/939

Matjaz, thanks for the quick help and for commenting! It is helpful to include a link to your pull request as well: https://github.com/mozilla/mozillians/pull/939

Comment 9

[Matjaz Verbole]

Acknowledged. Next time I will include a link too.
Thank you for your help.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/f271383b443907755493a262552ee7ff351891ba
[fix bug 980138] Display total number of results found for a search

https://github.com/mozilla/mozillians/commit/a3a88d20a93eab0379c0d5d7d97907de2dae57ce
Merge pull request #939 from matjazv/980138

[fix bug 980138] Display total number of results found for a search

Comment 11

[Matt Brandt [:mbrandt]]

QA verified on stage - counts look correct of groups, mozillians, mozillians + unvouched